From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shmulik Ladkani <shmulik@metanetworks.com>
Subject: Re: [PATCH iproute2-next] iproute_lwtunnel: allow specifying 'src'
 for 'encap ip' / 'encap ip6'
Date: Fri, 17 Aug 2018 20:37:29 +0300
Message-ID: <20180817203729.10c7a830@pixies>
References: <20180817073134.19569-1-shmulik.ladkani@gmail.com>
        <20180817080022.18e9992d@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dsahern@gmail.com, netdev@vger.kernel.org
To: Stephen Hemminger <stephen@networkplumber.org>,
        Shmulik Ladkani <shmulik.ladkani@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm0-f66.google.com ([74.125.82.66]:40130 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727445AbeHQUls (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 17 Aug 2018 16:41:48 -0400
Received: by mail-wm0-f66.google.com with SMTP id y9-v6so8086730wma.5
        for <netdev@vger.kernel.org>; Fri, 17 Aug 2018 10:37:32 -0700 (PDT)
In-Reply-To: <20180817080022.18e9992d@xeon-e3>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi,

On Fri, 17 Aug 2018 08:00:22 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> If you accept an attribute on input you need to parse it and display it the
> same way in the show command.

Note print_encap_ip and print_encap_ip6 already handle LWTUNNEL_IP_SRC
and LWTUNNEL_IP6_SRC (since long ago, 1e5293056 and d95cdcf52).

The only missing part is treatment in parse_encap_ip and
parse_encap_ip6, as suggested by this patch.

Best,
Shmulik