From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH 1/1] tap: RCU usage and comment fixes
Date: Sun, 19 Aug 2018 11:08:23 -0700 (PDT)
Message-ID: <20180819.110823.2099088108268644586.davem@davemloft.net>
References: <20180817082253.2539-1-jianjian.wang1@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: jasowang@redhat.com, mst@redhat.com, willemb@google.com,
        viro@zeniv.linux.org.uk, wexu@redhat.com, netdev@vger.kernel.org
To: jianjian.wang1@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:33632 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725959AbeHSVUo (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 19 Aug 2018 17:20:44 -0400
In-Reply-To: <20180817082253.2539-1-jianjian.wang1@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Wang Jian <jianjian.wang1@gmail.com>
Date: Fri, 17 Aug 2018 08:22:53 +0000

> The tap_queue and the 'tap_dev' are loosely coupled, not 'macvlan_dev'.

There is another reference to macvlan_dev in that comment, which is therefore
also similarly inaccurate.  You should add an appropriate Fixes: line for
where this inaccuracy was introduced, which is:

Fixes: 6fe3faf86757 ("tap: Abstract type of virtual interface from tap implementation")

> Taking rcu_read_lock a little later seems can slightly reduce rcu read critical section.

This is a separate change from fixing up a comment.