From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] ip6_vti: fix a null pointer deference when destroy vti6 tunnel Date: Sun, 19 Aug 2018 19:56:17 -0700 (PDT) Message-ID: <20180819.195617.287376807384738076.davem@davemloft.net> References: <1534733465-2493-1-git-send-email-yanhaishuang@cmss.chinamobile.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: steffen.klassert@secunet.com, kuznet@ms2.inr.ac.ru, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: yanhaishuang@cmss.chinamobile.com Return-path: In-Reply-To: <1534733465-2493-1-git-send-email-yanhaishuang@cmss.chinamobile.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Haishuang Yan Date: Mon, 20 Aug 2018 10:51:05 +0800 > If load ip6_vti module and create a network namespace when set > fb_tunnels_only_for_init_net to 1, then exit the namespace will > cause following crash: ... > This because ip6n->tnls_wc[0] point to fallback device in default, but > in non-default namespace, ip6n->tnls_wc[0] will be NULL, so add the NULL > check comparatively. > > Fixes: e2948e5af8ee ("ip6_vti: fix creating fallback tunnel device for vti6") > Signed-off-by: Haishuang Yan Ugh, applied, thanks.