From mboxrd@z Thu Jan 1 00:00:00 1970 From: Larry Finger Subject: [PATCH 1/2] staging: rtl8192e: Fix compiler warning about strncpy Date: Mon, 20 Aug 2018 12:51:23 -0500 Message-ID: <20180820175124.23863-2-Larry.Finger@lwfinger.net> References: <20180820175124.23863-1-Larry.Finger@lwfinger.net> Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, Larry Finger To: gregkh@linuxfoundation.org Return-path: Received: from mail-oi0-f66.google.com ([209.85.218.66]:34384 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbeHTVIM (ORCPT ); Mon, 20 Aug 2018 17:08:12 -0400 Received: by mail-oi0-f66.google.com with SMTP id 13-v6so27332652ois.1 for ; Mon, 20 Aug 2018 10:51:36 -0700 (PDT) In-Reply-To: <20180820175124.23863-1-Larry.Finger@lwfinger.net> Sender: netdev-owner@vger.kernel.org List-ID: When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger --- drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index 919231fec09c..95a8390cb7ac 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -1684,14 +1684,14 @@ inline void rtllib_softmac_new_net(struct rtllib_device *ieee, * essid provided by the user. */ if (!ssidbroad) { - strncpy(tmp_ssid, ieee->current_network.ssid, + strlcpy(tmp_ssid, ieee->current_network.ssid, IW_ESSID_MAX_SIZE); tmp_ssid_len = ieee->current_network.ssid_len; } memcpy(&ieee->current_network, net, sizeof(struct rtllib_network)); if (!ssidbroad) { - strncpy(ieee->current_network.ssid, tmp_ssid, + strlcpy(ieee->current_network.ssid, tmp_ssid, IW_ESSID_MAX_SIZE); ieee->current_network.ssid_len = tmp_ssid_len; } -- 2.18.0