[PATCHv2 iproute2 2/3] tc: remove extern from prototype declarations

[PATCHv2 iproute2 2/3] tc: remove extern from prototype declarations

[Mahesh Bandewar]

From: Mahesh Bandewar <maheshb@google.com>

Signed-off-by: Mahesh Bandewar <maheshb@google.com>
---
 tc/m_ematch.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tc/m_ematch.h b/tc/m_ematch.h
index f634f19164fa..80b02cfad6cc 100644
--- a/tc/m_ematch.h
+++ b/tc/m_ematch.h
@@ -20,7 +20,7 @@ struct bstr
 	struct bstr	*next;
 };
 
-extern struct bstr * bstr_alloc(const char *text);
+struct bstr * bstr_alloc(const char *text);
 
 static inline struct bstr * bstr_new(char *data, unsigned int len)
 {
@@ -51,8 +51,8 @@ static inline struct bstr *bstr_next(struct bstr *b)
 	return b->next;
 }
 
-extern unsigned long bstrtoul(const struct bstr *b);
-extern void bstr_print(FILE *fd, const struct bstr *b, int ascii);
+unsigned long bstrtoul(const struct bstr *b);
+void bstr_print(FILE *fd, const struct bstr *b, int ascii);
 
 
 struct ematch
@@ -79,7 +79,7 @@ static inline struct ematch * new_ematch(struct bstr *args, int inverted)
 	return e;
 }
 
-extern void print_ematch_tree(const struct ematch *tree);
+void print_ematch_tree(const struct ematch *tree);
 
 
 struct ematch_util
@@ -107,9 +107,9 @@ static inline int parse_layer(struct bstr *b)
 		return INT_MAX;
 }
 
-extern int em_parse_error(int err, struct bstr *args, struct bstr *carg,
+int em_parse_error(int err, struct bstr *args, struct bstr *carg,
 		   struct ematch_util *, char *fmt, ...);
-extern int print_ematch(FILE *, const struct rtattr *);
-extern int parse_ematch(int *, char ***, int, struct nlmsghdr *);
+int print_ematch(FILE *, const struct rtattr *);
+int parse_ematch(int *, char ***, int, struct nlmsghdr *);
 
 #endif
-- 
2.18.0.865.gffc8e1a3cd6-goog

Re: [PATCHv2 iproute2 2/3] tc: remove extern from prototype declarations

[Stephen Hemminger]

On Tue, 21 Aug 2018 10:48:54 -0700
Mahesh Bandewar <mahesh@bandewar.net> wrote:

> From: Mahesh Bandewar <maheshb@google.com>
> 
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>

I already did this yesterday. Patch was on mailing list.

Re: [PATCHv2 iproute2 2/3] tc: remove extern from prototype declarations

[Mahesh Bandewar (महेश बंडेवार)]

On Tue, Aug 21, 2018 at 11:19 AM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Tue, 21 Aug 2018 10:48:54 -0700
> Mahesh Bandewar <mahesh@bandewar.net> wrote:
>
>> From: Mahesh Bandewar <maheshb@google.com>
>>
>> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
>
> I already did this yesterday. Patch was on mailing list.
Hmm, I thought I did mention that I would take care in v2. In any
case, we can remove this from the patch-series if remaining patches
are fine. Does that make sense?