netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: kernel@pengutronix.de, netdev@vger.kernel.org, mdf@kernel.org,
	Brad Mouring <brad.mouring@ni.com>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH v3 net 0/1] net: macb: Fix regression breaking non-MDIO fixed-link PHYs
Date: Tue, 21 Aug 2018 17:35:47 +0200	[thread overview]
Message-ID: <20180821153548.11223-1-a.fatoum@pengutronix.de> (raw)

commit 739de9a1563a ("net: macb: Reorganize macb_mii bringup") broke
initializing macb on the EVB-KSZ9477 eval board.

The board's SoC has a macb MAC connected to the KSZ9477 over RGMII, this
is represented as a fixed-link as follows in the (non-mainline) device tree:

	macb0: ethernet@f0028000 {
		phy-mode = "rgmii";
		gpios = <&pioB 28 GPIO_ACTIVE_LOW>;
		reset-gpios = <&pioC 31 GPIO_ACTIVE_LOW>;
		status = "okay";
		
		fixed-link {
			speed = <1000>;
			full-duplex;
		};
	};

The following patch fixes the regression by partially reverting the offending
commit and can be backported to stable.

Follow-up patches that popped up during review will be sent when net-next opens.
They improve error reporting and add a "mdio" subtree binding to contain macb's
MDIO-managed PHYs, similar to the binding in other drivers.

This is v3. v2 started with
Message-Id: <20180820121238.7779-1-a.fatoum@pengutronix.de>.
without explicit marking as v2.
v1 started with Message-Id: <20180814141240.9085-1-a.fatoum@pengutronix.de>.

Changes introduced in v1 and v2 are noted in-line in their respective patches.


Ahmad Fatoum (1):
  net: macb: Fix regression breaking non-MDIO fixed-link PHYs

 drivers/net/ethernet/cadence/macb_main.c | 27 +++++++++++++++---------
 1 file changed, 17 insertions(+), 10 deletions(-)

-- 
2.18.0

             reply	other threads:[~2018-08-21 18:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21 15:35 Ahmad Fatoum [this message]
2018-08-21 15:35 ` [PATCH v3 net 1/1] net: macb: Fix regression breaking non-MDIO fixed-link PHYs Ahmad Fatoum
2018-08-26  0:31   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180821153548.11223-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=andrew@lunn.ch \
    --cc=brad.mouring@ni.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=mdf@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).