From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ahmad Fatoum Subject: [PATCH v3 net 0/1] net: macb: Fix regression breaking non-MDIO fixed-link PHYs Date: Tue, 21 Aug 2018 17:35:47 +0200 Message-ID: <20180821153548.11223-1-a.fatoum@pengutronix.de> Cc: kernel@pengutronix.de, netdev@vger.kernel.org, mdf@kernel.org, Brad Mouring , Florian Fainelli To: Andrew Lunn , "David S. Miller" , Nicolas Ferre Return-path: Received: from metis.ext.pengutronix.de ([85.220.165.71]:50153 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727353AbeHUS4j (ORCPT ); Tue, 21 Aug 2018 14:56:39 -0400 Sender: netdev-owner@vger.kernel.org List-ID: commit 739de9a1563a ("net: macb: Reorganize macb_mii bringup") broke initializing macb on the EVB-KSZ9477 eval board. The board's SoC has a macb MAC connected to the KSZ9477 over RGMII, this is represented as a fixed-link as follows in the (non-mainline) device tree: macb0: ethernet@f0028000 { phy-mode = "rgmii"; gpios = <&pioB 28 GPIO_ACTIVE_LOW>; reset-gpios = <&pioC 31 GPIO_ACTIVE_LOW>; status = "okay"; fixed-link { speed = <1000>; full-duplex; }; }; The following patch fixes the regression by partially reverting the offending commit and can be backported to stable. Follow-up patches that popped up during review will be sent when net-next opens. They improve error reporting and add a "mdio" subtree binding to contain macb's MDIO-managed PHYs, similar to the binding in other drivers. This is v3. v2 started with Message-Id: <20180820121238.7779-1-a.fatoum@pengutronix.de>. without explicit marking as v2. v1 started with Message-Id: <20180814141240.9085-1-a.fatoum@pengutronix.de>. Changes introduced in v1 and v2 are noted in-line in their respective patches. Ahmad Fatoum (1): net: macb: Fix regression breaking non-MDIO fixed-link PHYs drivers/net/ethernet/cadence/macb_main.c | 27 +++++++++++++++--------- 1 file changed, 17 insertions(+), 10 deletions(-) -- 2.18.0