From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [bpf PATCH 0/2] tls, sockmap, fixes for sk_wait_event Date: Wed, 22 Aug 2018 11:40:11 -0700 Message-ID: <20180822184009.m646ixyt7oh5nq45@ast-mbp> References: <20180822153314.27968.72499.stgit@john-Precision-Tower-5810> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ast@kernel.org, daniel@iogearbox.net, davejwatson@fb.com, netdev@vger.kernel.org, davem@davemloft.net To: John Fastabend Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:35144 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727602AbeHVWI1 (ORCPT ); Wed, 22 Aug 2018 18:08:27 -0400 Received: by mail-pl0-f66.google.com with SMTP id d9-v6so1055942plr.2 for ; Wed, 22 Aug 2018 11:42:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180822153314.27968.72499.stgit@john-Precision-Tower-5810> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Aug 22, 2018 at 08:37:27AM -0700, John Fastabend wrote: > I have been testing ktls and sockmap lately and noticed that neither > was handling sk_write_space events correctly. We need to ensure > these events are pushed down to the lower layer in all cases to > handle the case where the lower layer sendpage call has called > sk_wait_event and needs to be woken up. Without this I see > occosional stalls of sndtimeo length while we wait for the > timeout value even though space is available. > > Two fixes below. Thanks. for the set Acked-by: Alexei Starovoitov