Netdev List
 help / color / mirror / Atom feed
From: Kevin Yang <yyd@google.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Kevin Yang <yyd@google.com>,
	Neal Cardwell <ncardwell@google.com>
Subject: [PATCH net 2/3] tcp_bbr: in restart from idle, see if we should exit PROBE_RTT
Date: Wed, 22 Aug 2018 17:43:15 -0400	[thread overview]
Message-ID: <20180822214316.174161-3-yyd@google.com> (raw)
In-Reply-To: <20180822214316.174161-1-yyd@google.com>

This patch fix the case where BBR does not exit PROBE_RTT mode when
it restarts from idle. When BBR restarts from idle and if BBR is in
PROBE_RTT mode, BBR should check if it's time to exit PROBE_RTT. If
yes, then BBR should exit PROBE_RTT mode and restore the cwnd to its
full value.

Fixes: 0f8782ea1497 ("tcp_bbr: add BBR congestion control")
Signed-off-by: Kevin Yang <yyd@google.com>
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Reviewed-by: Yuchung Cheng <ycheng@google.com>
Reviewed-by: Soheil Hassas Yeganeh <soheil@google.com>
---
 net/ipv4/tcp_bbr.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/ipv4/tcp_bbr.c b/net/ipv4/tcp_bbr.c
index fd7bccf36a263..1d4bdd3b5e4d0 100644
--- a/net/ipv4/tcp_bbr.c
+++ b/net/ipv4/tcp_bbr.c
@@ -174,6 +174,8 @@ static const u32 bbr_lt_bw_diff = 4000 / 8;
 /* If we estimate we're policed, use lt_bw for this many round trips: */
 static const u32 bbr_lt_bw_max_rtts = 48;
 
+static void bbr_check_probe_rtt_done(struct sock *sk);
+
 /* Do we estimate that STARTUP filled the pipe? */
 static bool bbr_full_bw_reached(const struct sock *sk)
 {
@@ -308,6 +310,8 @@ static void bbr_cwnd_event(struct sock *sk, enum tcp_ca_event event)
 		 */
 		if (bbr->mode == BBR_PROBE_BW)
 			bbr_set_pacing_rate(sk, bbr_bw(sk), BBR_UNIT);
+		else if (bbr->mode == BBR_PROBE_RTT)
+			bbr_check_probe_rtt_done(sk);
 	}
 }
 
-- 
2.18.0.1017.ga543ac7ca45-goog

  parent reply	other threads:[~2018-08-23  1:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-22 21:43 [PATCH net 0/3] tcp_bbr: PROBE_RTT minor bug fixes Kevin Yang
2018-08-22 21:43 ` [PATCH net 1/3] tcp_bbr: add bbr_check_probe_rtt_done() helper Kevin Yang
2018-08-22 21:43 ` Kevin Yang [this message]
2018-08-22 21:43 ` [PATCH net 3/3] tcp_bbr: apply PROBE_RTT cwnd cap even if acked==0 Kevin Yang
2018-08-23  4:45 ` [PATCH net 0/3] tcp_bbr: PROBE_RTT minor bug fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180822214316.174161-3-yyd@google.com \
    --to=yyd@google.com \
    --cc=davem@davemloft.net \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox