From: Andrew Lunn <andrew@lunn.ch>
To: Peng Li <lipeng321@huawei.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
yisen.zhuang@huawei.com, salil.mehta@huawei.com
Subject: Re: [PATCH NET 3/3] net: hns: add configuration constraints for 1000M half
Date: Fri, 24 Aug 2018 05:41:19 +0200 [thread overview]
Message-ID: <20180824034119.GA29111@lunn.ch> (raw)
In-Reply-To: <1535082143-122281-4-git-send-email-lipeng321@huawei.com>
On Fri, Aug 24, 2018 at 11:42:23AM +0800, Peng Li wrote:
> Hisilicon hip05 and hip06 board network card do not support
> 1000M half configuration. Driver can not config gmac as
> 1000M half.
>
> Signed-off-by: Peng Li <lipeng321@huawei.com>
Hi Peng
Does the driver remove SUPPORTED_1000baseT_Half from
phydev->supported? If you do that, the PHY should never negotiate
this speed.
Andrew
next prev parent reply other threads:[~2018-08-24 3:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 3:42 [PATCH net 0/3] net: hns: fix some bugs about speed and duplex change Peng Li
2018-08-24 3:42 ` [PATCH NET 1/3] net: hns: add the code for cleaning pkt in chip Peng Li
2018-08-24 3:42 ` [PATCH NET 2/3] net: hns: add netif_carrier_off before change speed and duplex Peng Li
2018-08-24 3:42 ` [PATCH NET 3/3] net: hns: add configuration constraints for 1000M half Peng Li
2018-08-24 3:41 ` Andrew Lunn [this message]
2018-08-24 6:39 ` lipeng (Y)
2018-08-24 13:28 ` Andrew Lunn
2018-08-25 1:21 ` lipeng (Y)
2018-08-25 18:07 ` Andrew Lunn
2018-08-27 1:08 ` lipeng (Y)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180824034119.GA29111@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).