From: David Miller <davem@davemloft.net>
To: a.fatoum@pengutronix.de
Cc: andrew@lunn.ch, nicolas.ferre@microchip.com,
kernel@pengutronix.de, netdev@vger.kernel.org, mdf@kernel.org,
brad.mouring@ni.com, f.fainelli@gmail.com
Subject: Re: [PATCH v3 net 1/1] net: macb: Fix regression breaking non-MDIO fixed-link PHYs
Date: Sat, 25 Aug 2018 17:31:02 -0700 (PDT) [thread overview]
Message-ID: <20180825.173102.333761398996346302.davem@davemloft.net> (raw)
In-Reply-To: <20180821153548.11223-2-a.fatoum@pengutronix.de>
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Date: Tue, 21 Aug 2018 17:35:48 +0200
> commit 739de9a1563a ("net: macb: Reorganize macb_mii bringup") broke
> initializing macb on the EVB-KSZ9477 eval board.
> There, of_mdiobus_register was called even for the fixed-link representing
> the RGMII-link to the switch with the result that the driver attempts to
> enumerate PHYs on a non-existent MDIO bus:
>
> libphy: MACB_mii_bus: probed
> mdio_bus f0028000.ethernet-ffffffff: fixed-link has invalid PHY address
> mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 0
> [snip]
> mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 31
>
> The "MDIO" bus registration succeeds regardless, having claimed the reset GPIO,
> and calling of_phy_register_fixed_link later on fails because it tries
> to claim the same GPIO:
>
> macb f0028000.ethernet: broken fixed-link specification
>
> Fix this by registering the fixed-link before calling mdiobus_register.
>
> Fixes: 739de9a1563a ("net: macb: Reorganize macb_mii bringup")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2018-08-26 4:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 15:35 [PATCH v3 net 0/1] net: macb: Fix regression breaking non-MDIO fixed-link PHYs Ahmad Fatoum
2018-08-21 15:35 ` [PATCH v3 net 1/1] " Ahmad Fatoum
2018-08-26 0:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180825.173102.333761398996346302.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.fatoum@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=brad.mouring@ni.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=mdf@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).