From: David Miller <davem@davemloft.net>
To: manish.chopra@cavium.com
Cc: netdev@vger.kernel.org, Dept-GELinuxNICDev@cavium.com, bpoirier@suse.com
Subject: Re: [PATCH net 1/1] qlge: Fix netdev features configuration.
Date: Sat, 25 Aug 2018 17:38:29 -0700 (PDT) [thread overview]
Message-ID: <20180825.173829.1893118882508364882.davem@davemloft.net> (raw)
In-Reply-To: <20180823202052.10329-1-manish.chopra@cavium.com>
From: Manish Chopra <manish.chopra@cavium.com>
Date: Thu, 23 Aug 2018 13:20:52 -0700
> qlge_fix_features() is not supposed to modify hardware or
> driver state, rather it is supposed to only fix requested
> fetures bits. Currently qlge_fix_features() also goes for
> interface down and up unnecessarily if there is not even
> any change in features set.
>
> This patch changes/fixes following -
>
> 1) Move reload of interface or device re-config from
> qlge_fix_features() to qlge_set_features().
> 2) Reload of interface in qlge_set_features() only if
> relevant feature bit (NETIF_F_HW_VLAN_CTAG_RX) is changed.
> 3) Get rid of qlge_fix_features() since driver is not really
> required to fix any features bit.
>
> Signed-off-by: Manish <manish.chopra@cavium.com>
> Reviewed-by: Benjamin Poirier <bpoirier@suse.com>
Applied and queued up for -stable.
Please provide a proper Fixes: tag next time.
Thanks.
next prev parent reply other threads:[~2018-08-26 4:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 20:20 [PATCH net 1/1] qlge: Fix netdev features configuration Manish Chopra
2018-08-26 0:38 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-23 20:32 Manish Chopra
2018-08-23 21:59 ` Chopra, Manish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180825.173829.1893118882508364882.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept-GELinuxNICDev@cavium.com \
--cc=bpoirier@suse.com \
--cc=manish.chopra@cavium.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).