* [PATCH] correct comments for flags, priv flags in netdevice.h
@ 2018-08-24 23:10 Robert P. J. Day
2018-08-25 0:38 ` Andrew Lunn
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2018-08-24 23:10 UTC (permalink / raw)
To: Linux kernel netdev mailing list
Correct the references for both flags and priv flags since they both
refer to the incorrect file which contains their explanations.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index ca5ab98053c8..f01f3473bb91 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1586,9 +1586,9 @@ enum netdev_priv_flags {
* @header_ops: Includes callbacks for creating,parsing,caching,etc
* of Layer 2 headers.
*
- * @flags: Interface flags (a la BSD)
- * @priv_flags: Like 'flags' but invisible to userspace,
- * see if.h for the definitions
+ * @flags: Interface flags (a la BSD), see if.h for definitions
+ * @priv_flags: Like 'flags' but invisible to userspace, see
+ * definitions earlier in this file
* @gflags: Global flags ( kept as legacy )
* @padded: How much padding added by alloc_netdev()
* @operstate: RFC2863 operstate
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] correct comments for flags, priv flags in netdevice.h
2018-08-24 23:10 [PATCH] correct comments for flags, priv flags in netdevice.h Robert P. J. Day
@ 2018-08-25 0:38 ` Andrew Lunn
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2018-08-25 0:38 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux kernel netdev mailing list
On Fri, Aug 24, 2018 at 07:10:20PM -0400, Robert P. J. Day wrote:
> Correct the references for both flags and priv flags since they both
> refer to the incorrect file which contains their explanations.
Hi Robert
I'm guessing this is your first patch for Linux?
Please use git send-email to sending patches. That will avoid the
signature being added, and any other mangling your email client may
do.
The subject line should indicate what tree the patch is for:
[PATCH net-next] correct comments for flags, priv flags in netdevice.h
You can do this with git format-patch --subject "PATCH net-next".
And lastly, net-next is closed at the moment, because the merge window
is open. DaveM will send an email when he is read to accept patches, a
few days after -rc1 is out.
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-25 4:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-24 23:10 [PATCH] correct comments for flags, priv flags in netdevice.h Robert P. J. Day
2018-08-25 0:38 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).