From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] erspan: set erspan_ver to 1 by default when adding an erspan dev Date: Mon, 27 Aug 2018 15:14:11 -0700 (PDT) Message-ID: <20180827.151411.320401579557716362.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, u9012063@gmail.com To: lucien.xin@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:33568 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727023AbeH1CCo (ORCPT ); Mon, 27 Aug 2018 22:02:44 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Xin Long Date: Mon, 27 Aug 2018 18:41:32 +0800 > After erspan_ver is introudced, if erspan_ver is not set in iproute, its > value will be left 0 by default. Since Commit 02f99df1875c ("erspan: fix > invalid erspan version."), it has broken the traffic due to the version > check in erspan_xmit if users are not aware of 'erspan_ver' param, like > using an old version of iproute. > > To fix this compatibility problem, it sets erspan_ver to 1 by default > when adding an erspan dev in erspan_setup. Note that we can't do it in > ipgre_netlink_parms, as this function is also used by ipgre_changelink. > > Fixes: 02f99df1875c ("erspan: fix invalid erspan version.") > Reported-by: Jianlin Shi > Signed-off-by: Xin Long Applied and queued up for -stable.