* [PATCH net] sctp: remove useless start_fail from sctp_ht_iter in proc
@ 2018-08-27 10:40 Xin Long
2018-08-27 13:13 ` Neil Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Xin Long @ 2018-08-27 10:40 UTC (permalink / raw)
To: network dev, linux-sctp; +Cc: davem, Marcelo Ricardo Leitner, Neil Horman
After changing rhashtable_walk_start to return void, start_fail would
never be set other value than 0, and the checking for start_fail is
pointless, so remove it.
Fixes: 97a6ec4ac021 ("rhashtable: Change rhashtable_walk_start to return void")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
net/sctp/proc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/net/sctp/proc.c b/net/sctp/proc.c
index 4d6f1c8..a644292 100644
--- a/net/sctp/proc.c
+++ b/net/sctp/proc.c
@@ -215,7 +215,6 @@ static const struct seq_operations sctp_eps_ops = {
struct sctp_ht_iter {
struct seq_net_private p;
struct rhashtable_iter hti;
- int start_fail;
};
static void *sctp_transport_seq_start(struct seq_file *seq, loff_t *pos)
@@ -224,7 +223,6 @@ static void *sctp_transport_seq_start(struct seq_file *seq, loff_t *pos)
sctp_transport_walk_start(&iter->hti);
- iter->start_fail = 0;
return sctp_transport_get_idx(seq_file_net(seq), &iter->hti, *pos);
}
@@ -232,8 +230,6 @@ static void sctp_transport_seq_stop(struct seq_file *seq, void *v)
{
struct sctp_ht_iter *iter = seq->private;
- if (iter->start_fail)
- return;
sctp_transport_walk_stop(&iter->hti);
}
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] sctp: remove useless start_fail from sctp_ht_iter in proc
2018-08-27 10:40 [PATCH net] sctp: remove useless start_fail from sctp_ht_iter in proc Xin Long
@ 2018-08-27 13:13 ` Neil Horman
2018-08-27 13:30 ` Marcelo Ricardo Leitner
2018-08-27 22:14 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Neil Horman @ 2018-08-27 13:13 UTC (permalink / raw)
To: Xin Long; +Cc: network dev, linux-sctp, davem, Marcelo Ricardo Leitner
On Mon, Aug 27, 2018 at 06:40:18PM +0800, Xin Long wrote:
> After changing rhashtable_walk_start to return void, start_fail would
> never be set other value than 0, and the checking for start_fail is
> pointless, so remove it.
>
> Fixes: 97a6ec4ac021 ("rhashtable: Change rhashtable_walk_start to return void")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/sctp/proc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/net/sctp/proc.c b/net/sctp/proc.c
> index 4d6f1c8..a644292 100644
> --- a/net/sctp/proc.c
> +++ b/net/sctp/proc.c
> @@ -215,7 +215,6 @@ static const struct seq_operations sctp_eps_ops = {
> struct sctp_ht_iter {
> struct seq_net_private p;
> struct rhashtable_iter hti;
> - int start_fail;
> };
>
> static void *sctp_transport_seq_start(struct seq_file *seq, loff_t *pos)
> @@ -224,7 +223,6 @@ static void *sctp_transport_seq_start(struct seq_file *seq, loff_t *pos)
>
> sctp_transport_walk_start(&iter->hti);
>
> - iter->start_fail = 0;
> return sctp_transport_get_idx(seq_file_net(seq), &iter->hti, *pos);
> }
>
> @@ -232,8 +230,6 @@ static void sctp_transport_seq_stop(struct seq_file *seq, void *v)
> {
> struct sctp_ht_iter *iter = seq->private;
>
> - if (iter->start_fail)
> - return;
> sctp_transport_walk_stop(&iter->hti);
> }
>
> --
> 2.1.0
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] sctp: remove useless start_fail from sctp_ht_iter in proc
2018-08-27 10:40 [PATCH net] sctp: remove useless start_fail from sctp_ht_iter in proc Xin Long
2018-08-27 13:13 ` Neil Horman
@ 2018-08-27 13:30 ` Marcelo Ricardo Leitner
2018-08-27 22:14 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Marcelo Ricardo Leitner @ 2018-08-27 13:30 UTC (permalink / raw)
To: Xin Long; +Cc: network dev, linux-sctp, davem, Neil Horman
On Mon, Aug 27, 2018 at 06:40:18PM +0800, Xin Long wrote:
> After changing rhashtable_walk_start to return void, start_fail would
> never be set other value than 0, and the checking for start_fail is
> pointless, so remove it.
>
> Fixes: 97a6ec4ac021 ("rhashtable: Change rhashtable_walk_start to return void")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> net/sctp/proc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/net/sctp/proc.c b/net/sctp/proc.c
> index 4d6f1c8..a644292 100644
> --- a/net/sctp/proc.c
> +++ b/net/sctp/proc.c
> @@ -215,7 +215,6 @@ static const struct seq_operations sctp_eps_ops = {
> struct sctp_ht_iter {
> struct seq_net_private p;
> struct rhashtable_iter hti;
> - int start_fail;
> };
>
> static void *sctp_transport_seq_start(struct seq_file *seq, loff_t *pos)
> @@ -224,7 +223,6 @@ static void *sctp_transport_seq_start(struct seq_file *seq, loff_t *pos)
>
> sctp_transport_walk_start(&iter->hti);
>
> - iter->start_fail = 0;
> return sctp_transport_get_idx(seq_file_net(seq), &iter->hti, *pos);
> }
>
> @@ -232,8 +230,6 @@ static void sctp_transport_seq_stop(struct seq_file *seq, void *v)
> {
> struct sctp_ht_iter *iter = seq->private;
>
> - if (iter->start_fail)
> - return;
> sctp_transport_walk_stop(&iter->hti);
> }
>
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] sctp: remove useless start_fail from sctp_ht_iter in proc
2018-08-27 10:40 [PATCH net] sctp: remove useless start_fail from sctp_ht_iter in proc Xin Long
2018-08-27 13:13 ` Neil Horman
2018-08-27 13:30 ` Marcelo Ricardo Leitner
@ 2018-08-27 22:14 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-08-27 22:14 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, linux-sctp, marcelo.leitner, nhorman
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 27 Aug 2018 18:40:18 +0800
> After changing rhashtable_walk_start to return void, start_fail would
> never be set other value than 0, and the checking for start_fail is
> pointless, so remove it.
>
> Fixes: 97a6ec4ac021 ("rhashtable: Change rhashtable_walk_start to return void")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-28 2:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-27 10:40 [PATCH net] sctp: remove useless start_fail from sctp_ht_iter in proc Xin Long
2018-08-27 13:13 ` Neil Horman
2018-08-27 13:30 ` Marcelo Ricardo Leitner
2018-08-27 22:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).