From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: [PATCH 4/4] RFC: r8169: Disable clk during suspend / resume Date: Mon, 27 Aug 2018 16:32:00 +0200 Message-ID: <20180827143200.8597-5-hdegoede@redhat.com> References: <20180827143200.8597-1-hdegoede@redhat.com> Cc: Hans de Goede , netdev@vger.kernel.org, Johannes Stezenbach , Carlo Caione , linux-clk@vger.kernel.org To: "David S . Miller" , Heiner Kallweit , Michael Turquette , Stephen Boyd , Andy Shevchenko , Irina Tirdea Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50984 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726953AbeH0STD (ORCPT ); Mon, 27 Aug 2018 14:19:03 -0400 In-Reply-To: <20180827143200.8597-1-hdegoede@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: Disable the clk during suspend to save power. Note that tp->clk may be NULL, the clk core functions handle this without problems. Signed-off-by: Hans de Goede --- drivers/net/ethernet/realtek/r8169.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 779b02979493..aebc90158bd9 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -7312,8 +7312,10 @@ static int rtl8169_suspend(struct device *device) { struct pci_dev *pdev = to_pci_dev(device); struct net_device *dev = pci_get_drvdata(pdev); + struct rtl8169_private *tp = netdev_priv(dev); rtl8169_net_suspend(dev); + clk_disable_unprepare(tp->clk); return 0; } @@ -7340,6 +7342,7 @@ static int rtl8169_resume(struct device *device) struct net_device *dev = pci_get_drvdata(pdev); struct rtl8169_private *tp = netdev_priv(dev); + clk_prepare_enable(tp->clk); rtl8169_init_phy(dev, tp); if (netif_running(dev)) -- 2.18.0