From mboxrd@z Thu Jan 1 00:00:00 1970 From: Larry Finger Subject: [PATCH v2 2/2] staging: rtl8712u: Fix compiler warning about strncpy Date: Mon, 27 Aug 2018 13:46:46 -0500 Message-ID: <20180827184646.10276-3-Larry.Finger@lwfinger.net> References: <20180827184646.10276-1-Larry.Finger@lwfinger.net> Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, Larry Finger To: gregkh@linuxfoundation.org Return-path: Received: from mail-oi0-f66.google.com ([209.85.218.66]:35660 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727136AbeH0Wel (ORCPT ); Mon, 27 Aug 2018 18:34:41 -0400 Received: by mail-oi0-f66.google.com with SMTP id m11-v6so29192330oic.2 for ; Mon, 27 Aug 2018 11:46:54 -0700 (PDT) In-Reply-To: <20180827184646.10276-1-Larry.Finger@lwfinger.net> Sender: netdev-owner@vger.kernel.org List-ID: When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger --- v2 - No changes. --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c index c3ff7c3e6681..08e1c0957a07 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c @@ -1789,7 +1789,7 @@ static int r871x_wx_set_enc_ext(struct net_device *dev, return -ENOMEM; param->cmd = IEEE_CMD_SET_ENCRYPTION; eth_broadcast_addr(param->sta_addr); - strncpy((char *)param->u.crypt.alg, alg_name, IEEE_CRYPT_ALG_NAME_LEN); + strlcpy((char *)param->u.crypt.alg, alg_name, IEEE_CRYPT_ALG_NAME_LEN); if (pext->ext_flags & IW_ENCODE_EXT_GROUP_KEY) param->u.crypt.set_tx = 0; if (pext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY) -- 2.18.0