netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: jacob.e.keller@intel.com, netdev@vger.kernel.org,
	nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com
Subject: Re: [net-next 02/15] i40e: move ethtool stats boiler plate code to i40e_ethtool_stats.h
Date: Wed, 29 Aug 2018 20:05:26 -0700 (PDT)	[thread overview]
Message-ID: <20180829.200526.960850869217922028.davem@davemloft.net> (raw)
In-Reply-To: <20180829224834.3141-3-jeffrey.t.kirsher@intel.com>

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 29 Aug 2018 15:48:21 -0700

> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h b/drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h
> new file mode 100644
> index 000000000000..0290ade7494b
> --- /dev/null
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h
> @@ -0,0 +1,221 @@
...
> +/**
> + * __i40e_add_stat_strings - copy stat strings into ethtool buffer
> + * @p: ethtool supplied buffer
> + * @stats: stat definitions array
> + * @size: size of the stats array
> + *
> + * Format and copy the strings described by stats into the buffer pointed at
> + * by p.
> + **/
> +static void __i40e_add_stat_strings(u8 **p, const struct i40e_stats stats[],
> +				    const unsigned int size, ...)

Need to be marked inline.

  reply	other threads:[~2018-08-30  7:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 22:48 [net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2018-08-29 Jeff Kirsher
2018-08-29 22:48 ` [net-next 01/15] i40e: convert queue stats to i40e_stats array Jeff Kirsher
2018-08-29 22:48 ` [net-next 02/15] i40e: move ethtool stats boiler plate code to i40e_ethtool_stats.h Jeff Kirsher
2018-08-30  3:05   ` David Miller [this message]
2018-09-04  6:41     ` Keller, Jacob E
2018-08-29 22:48 ` [net-next 03/15] i40evf: update ethtool stats code and use helper functions Jeff Kirsher
2018-08-29 22:48 ` [net-next 04/15] i40evf: Change a VF mac without reloading the VF driver Jeff Kirsher
2018-08-29 22:48 ` [net-next 05/15] i40evf: Validate the number of queues a PF sends Jeff Kirsher
2018-08-29 22:48 ` [net-next 06/15] i40e: use correct length for strncpy Jeff Kirsher
2018-08-29 22:48 ` [net-next 07/15] i40evf: set IFF_UNICAST_FLT flag for the VF Jeff Kirsher
2018-08-29 22:48 ` [net-next 08/15] virtchnl: use u8 type for a field in the virtchnl_filter struct Jeff Kirsher
2018-08-29 22:48 ` [net-next 09/15] i40e: static analysis report from community Jeff Kirsher
2018-08-29 22:48 ` [net-next 10/15] i40e: report correct statistics when XDP is enabled Jeff Kirsher
2018-08-29 22:48 ` [net-next 11/15] i40e: Check and correct speed values for link on open Jeff Kirsher
2018-08-29 22:48 ` [net-next 12/15] i40evf: Don't enable vlan stripping when rx offload is turned on Jeff Kirsher
2018-08-29 22:48 ` [net-next 13/15] i40e: hold the rtnl lock on clearing interrupt scheme Jeff Kirsher
2018-08-29 22:48 ` [net-next 14/15] i40evf: cancel workqueue sync for adminq when a VF is removed Jeff Kirsher
2018-08-29 22:48 ` [net-next 15/15] i40e: Prevent deleting MAC address from VF when set by PF Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180829.200526.960850869217922028.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jacob.e.keller@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jogreene@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).