From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [Patch iproute2] ss: add UNIX_DIAG_VFS and UNIX_DIAG_ICONS for
 unix sockets
Date: Wed, 29 Aug 2018 08:41:51 -0700
Message-ID: <20180829084151.19fb9ef7@xeon-e3>
References: <20180827214652.29318-1-xiyou.wangcong@gmail.com>
        <20180827152725.479342e7@shemminger-XPS-13-9360>
        <CAM_iQpWod288CWHmDzzVkrdivjQtTBY+ES4hErMRkqY4=r6TfQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f196.google.com ([209.85.210.196]:34072 "EHLO
        mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728911AbeH2Tj2 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 29 Aug 2018 15:39:28 -0400
Received: by mail-pf1-f196.google.com with SMTP id k19-v6so2464423pfi.1
        for <netdev@vger.kernel.org>; Wed, 29 Aug 2018 08:41:58 -0700 (PDT)
In-Reply-To: <CAM_iQpWod288CWHmDzzVkrdivjQtTBY+ES4hErMRkqY4=r6TfQ@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, 28 Aug 2018 16:16:49 -0700
Cong Wang <xiyou.wangcong@gmail.com> wrote:

> On Mon, Aug 27, 2018 at 3:27 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > On Mon, 27 Aug 2018 14:46:52 -0700
> > Cong Wang <xiyou.wangcong@gmail.com> wrote:
> >  
> > > UNIX_DIAG_VFS and UNIX_DIAG_ICONS are never used by ss,
> > > make them available in ss -e output.
> > >
> > > Cc: Stephen Hemminger <stephen@networkplumber.org>
> > > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> > > ---
> > >  misc/ss.c | 25 +++++++++++++++++++++++++
> > >  1 file changed, 25 insertions(+)
> > >
> > > diff --git a/misc/ss.c b/misc/ss.c
> > > index 41e7762b..d28bc1ec 100644
> > > --- a/misc/ss.c
> > > +++ b/misc/ss.c
> > > @@ -16,6 +16,7 @@
> > >  #include <sys/ioctl.h>
> > >  #include <sys/socket.h>
> > >  #include <sys/uio.h>
> > > +#include <sys/sysmacros.h>  
> >
> > Why is this included, it isn't on my system.  
> 
> It is for major() and minor().

Ok on Debian, these are in the architecture include, so this will work fine.