From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net v2 1/2] net_sched: reject unknown tcfa_action values Date: Wed, 29 Aug 2018 10:52:53 +0200 Message-ID: <20180829085252.GD2181@nanopsycho> References: <0aca759d71e70f359e51d517f9b1c087b4868fa1.1535527298.git.pabeni@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Jamal Hadi Salim , Cong Wang , "David S . Miller" , Davide Caratti , Lucas Bates To: Paolo Abeni Return-path: Received: from mail-wm0-f48.google.com ([74.125.82.48]:34069 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727770AbeH2Mw3 (ORCPT ); Wed, 29 Aug 2018 08:52:29 -0400 Received: by mail-wm0-f48.google.com with SMTP id m199-v6so3914528wma.1 for ; Wed, 29 Aug 2018 01:56:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <0aca759d71e70f359e51d517f9b1c087b4868fa1.1535527298.git.pabeni@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Aug 29, 2018 at 10:22:33AM CEST, pabeni@redhat.com wrote: >After the commit 802bfb19152c ("net/sched: user-space can't set >unknown tcfa_action values"), unknown tcfa_action values are >converted to TC_ACT_UNSPEC, but the common agreement is instead >rejecting such configurations. > >This change also introduces a helper to simplify the destruction >of a single action, avoiding code duplication. > >v1 -> v2: > - helper is now static and renamed according to act_* convention > - updated extack message, according to the new behavior > >Fixes: 802bfb19152c ("net/sched: user-space can't set unknown tcfa_action values") >Signed-off-by: Paolo Abeni Acked-by: Jiri Pirko