From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Cc: devel@driverdev.osuosl.org, andrew@lunn.ch, horia.geanta@nxp.com,
madalin.bucur@nxp.com, netdev@vger.kernel.org,
ioana.ciornei@nxp.com, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, davem@davemloft.net,
laurentiu.tudor@nxp.com
Subject: Re: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver
Date: Wed, 29 Aug 2018 14:07:39 +0300 [thread overview]
Message-ID: <20180829110739.3xzbdtelwjlhun2v@mwanda> (raw)
In-Reply-To: <20180829094240.27242-1-ruxandra.radulescu@nxp.com>
There are a few static checker warnings for the driver but only the
first one looks like a possibly real bug.
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1116 dpaa2_eth_stop() error: uninitialized symbol 'dpni_enabled'.
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1671 set_fq_affinity() warn: 'xps_mask' puts 1024 bytes on stack
drivers/staging/fsl-dpaa2/ethsw/ethsw.c:742 port_vlans_add() error: uninitialized symbol 'err'.
drivers/staging/fsl-dpaa2/ethsw/ethsw.c:886 port_vlans_del() error: uninitialized symbol 'err'.
regards,
dan carpenter
next prev parent reply other threads:[~2018-08-29 11:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 9:42 [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver Ioana Radulescu
2018-08-29 9:42 ` [PATCH net-next v2 1/2] staging: fsl-dpaa2/eth: Delay netdev_register() call Ioana Radulescu
2018-08-29 9:42 ` [PATCH net-next v2 2/2] dpaa2-eth: Move DPAA2 Ethernet driver from staging to drivers/net Ioana Radulescu
2018-08-29 10:50 ` Joe Perches
2018-08-29 13:21 ` Andrew Lunn
2018-08-29 11:07 ` Dan Carpenter [this message]
2018-08-29 12:06 ` [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver Ioana Ciocoi Radulescu
2018-08-29 12:15 ` Dan Carpenter
2018-09-02 0:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829110739.3xzbdtelwjlhun2v@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=horia.geanta@nxp.com \
--cc=ioana.ciornei@nxp.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox