netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Joe Perches <joe@perches.com>
Cc: Ioana Radulescu <ruxandra.radulescu@nxp.com>,
	netdev@vger.kernel.org, davem@davemloft.net,
	gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, ioana.ciornei@nxp.com,
	laurentiu.tudor@nxp.com, madalin.bucur@nxp.com,
	horia.geanta@nxp.com
Subject: Re: [PATCH net-next v2 2/2] dpaa2-eth: Move DPAA2 Ethernet driver from staging to drivers/net
Date: Wed, 29 Aug 2018 15:21:11 +0200	[thread overview]
Message-ID: <20180829132111.GF1955@lunn.ch> (raw)
In-Reply-To: <7dbd5426426315977a8dc7e1745d3addce3d16b5.camel@perches.com>

On Wed, Aug 29, 2018 at 03:50:02AM -0700, Joe Perches wrote:
> On Wed, 2018-08-29 at 04:42 -0500, Ioana Radulescu wrote:
> > The DPAA2 Ethernet driver supports Freescale/NXP SoCs with DPAA2
> > (DataPath Acceleration Architecture v2). The driver manages
> > network objects discovered on the fsl-mc bus.
> 
> Please use git 'format-patch -M' to make the diff
> smaller and more readable.

Hi Joe

I asked for this.

This is a request to move the driver from staging into the main
tree. We want to review the code in order to see if it has reached
mainline quality.

If the patch just lists a rename, not actually code, i cannot review
it, so i will just NACK it. We need to see the code.

Once the code has been reviewed and has all the needed Acked-by:, then
-M could be used. But this driver is not that far yet.

Thanks

    Andrew

  reply	other threads:[~2018-08-29 13:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29  9:42 [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver Ioana Radulescu
2018-08-29  9:42 ` [PATCH net-next v2 1/2] staging: fsl-dpaa2/eth: Delay netdev_register() call Ioana Radulescu
2018-08-29  9:42 ` [PATCH net-next v2 2/2] dpaa2-eth: Move DPAA2 Ethernet driver from staging to drivers/net Ioana Radulescu
2018-08-29 10:50   ` Joe Perches
2018-08-29 13:21     ` Andrew Lunn [this message]
2018-08-29 11:07 ` [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver Dan Carpenter
2018-08-29 12:06   ` Ioana Ciocoi Radulescu
2018-08-29 12:15     ` Dan Carpenter
2018-09-02  0:17 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180829132111.GF1955@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=horia.geanta@nxp.com \
    --cc=ioana.ciornei@nxp.com \
    --cc=joe@perches.com \
    --cc=laurentiu.tudor@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madalin.bucur@nxp.com \
    --cc=netdev@vger.kernel.org \
    --cc=ruxandra.radulescu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).