From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jisheng Zhang Subject: Re: [PATCH 1/5] net: mvneta: fix rx_offset_correction set and usage Date: Wed, 29 Aug 2018 17:16:08 +0800 Message-ID: <20180829171608.5eb7eb97@xhacker.debian> References: <20180829162456.2bd69796@xhacker.debian> <20180829162706.24111f9c@xhacker.debian> <87efehk0eu.fsf@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, "David S. Miller" , linux-arm-kernel@lists.infradead.org To: Gregory CLEMENT Return-path: In-Reply-To: <87efehk0eu.fsf@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org SGksCgpPbiBXZWQsIDI5IEF1ZyAyMDE4IDExOjA1OjQ1ICswMjAwIEdyZWdvcnkgQ0xFTUVOVCB3 cm90ZToKCj4gSGkgSmlzaGVuZywKPiAgCj4gIE9uIG1lci4sIGFvw7t0IDI5IDIwMTgsIEppc2hl bmcgWmhhbmcgPEppc2hlbmcuWmhhbmdAc3luYXB0aWNzLmNvbT4gd3JvdGU6Cj4gCj4gPiBUaGUg cnhfb2Zmc2V0X2NvcnJlY3Rpb24gaXMgUlggcGFja2V0IG9mZnNldCBjb3JyZWN0aW9uIGZvciBw bGF0Zm9ybXMsCj4gPiBpdCdzIG5vdCByZWxhdGVkIHdpdGggU1cgQk0sIGluc3RlYWQsIGl0J3Mg b25seSByZWxhdGVkIHdpdGggdGhlCj4gPiBwbGF0Zm9ybSdzIE5FVF9TS0JfUEFELgo+ID4gIAo+ IAo+IEJ1dCBpZiBJIHVuZHJlc3Rvb2Qgd2VsbCwgdGhlIHZhbHVlIG9mIHJ4X29mZnNldF9jb3Jy ZWN0aW9uIGhhcyBhbgo+IGluZmx1ZW5jZSBvbmx5IHdoZW4gd2UgdXNlIEhXIEJNLgoKVGhlIHJ4 X29mZnNldF9jb3JyZWN0aW9uIGlzIGludHJvZHVjZWQgYnkgY29tbWl0IDhkNTA0N2NmOWNhMiAo Im5ldDogbXZuZXRhOgogQ29udmVydCB0byBiZSA2NCBiaXRzIGNvbXBhdGlibGUiKS4gSXQncyB0 byBzdXBwb3J0IG12bmV0YSBvbiA2NGJpdApwbGF0Zm9ybXMgc3VjaCBhcyBBcm1hZGEgMzcwMC4g SXQncyBub3QgcmVsYXRlZCB3aXRoIEhXIEJNLgoKPiAKPiBIb3dldmVyIHNpbmNlIGQ5MzI3N2I5 ODM5YiAoIlJldmVydCAiYXJtNjQ6IEluY3JlYXNlIHRoZSBtYXggZ3JhbnVsYXIKPiBzaXplIiIp LCBORVRfU0tCX1BBRCBpcyA2NCBmb3IgYXJtNjQsIHNvIGluIHRoZSBlbmQgcnhfb2Zmc2V0X2Nv cnJlY3Rpb24KPiBpcyBhbHdheXMgMCBmb3IgcmVjZW50IGtlcm5lbHMuCgp5ZXMsIEkgbWVudGlv bmVkIHRoaXMgaW4gZW1haWwgIltxdWVyeV0gYWJvdXQgcmVjZW50IG12bmV0YSBwYXRjaGVzIi4K SU1ITywgd2UnZCBiZXR0ZXIgbm90IHJlbHkgb24gdGhlIHBsYXRmb3JtJ3MgTDFfQ0FDSEVfQllU RVMgdmFsdWUsCndlIGR1bm5vIHdoZXRoZXIgdGhlIG1heCBncmFudWxhciBzaXplIGlzIGluY3Jl YXNlZCBhZ2FpbiBpbiB0aGUgZnV0dXJlLgoKVGhhbmtzCgo+IAo+IEdyZWdvcnkKPiAKPiAKPiA+ IEZpeCB0aGUgaXNzdWUgYnkgcmV2ZXJ0aW5nIHRvIHRoZSBvcmlnaW5hbCBiZWhhdmlvci4KPiA+ Cj4gPiBGaXhlczogNTYyZTJmNDY3ZTcxICgibmV0OiBtdm5ldGE6IEltcHJvdmUgdGhlIGJ1ZmZl ciBhbGxvY2F0aW9uIG1ldGhvZCBmb3IgU1dCTSIpCj4gPiBTaWduZWQtb2ZmLWJ5OiBKaXNoZW5n IFpoYW5nIDxKaXNoZW5nLlpoYW5nQHN5bmFwdGljcy5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJz L25ldC9ldGhlcm5ldC9tYXJ2ZWxsL212bmV0YS5jIHwgMjQgKysrKysrKysrKy0tLS0tLS0tLS0t LS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygt KQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9tYXJ2ZWxsL212bmV0 YS5jIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvbWFydmVsbC9tdm5ldGEuYwo+ID4gaW5kZXggYmM4 MGE2NzhhYmMzLi4wY2U5NGY2NTg3YTUgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL25ldC9ldGhl cm5ldC9tYXJ2ZWxsL212bmV0YS5jCj4gPiArKysgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9tYXJ2 ZWxsL212bmV0YS5jCj4gPiBAQCAtMjg5OSwyMSArMjg5OSwxOCBAQCBzdGF0aWMgdm9pZCBtdm5l dGFfcnhxX2h3X2luaXQoc3RydWN0IG12bmV0YV9wb3J0ICpwcCwKPiA+ICAJbXZyZWdfd3JpdGUo cHAsIE1WTkVUQV9SWFFfQkFTRV9BRERSX1JFRyhyeHEtPmlkKSwgcnhxLT5kZXNjc19waHlzKTsK PiA+ICAJbXZyZWdfd3JpdGUocHAsIE1WTkVUQV9SWFFfU0laRV9SRUcocnhxLT5pZCksIHJ4cS0+ c2l6ZSk7Cj4gPiAgCj4gPiArCS8qIFNldCBPZmZzZXQgKi8KPiA+ICsJbXZuZXRhX3J4cV9vZmZz ZXRfc2V0KHBwLCByeHEsIE5FVF9TS0JfUEFEIC0gcHAtPnJ4X29mZnNldF9jb3JyZWN0aW9uKTsK PiA+ICsKPiA+ICAJLyogU2V0IGNvYWxlc2NpbmcgcGt0cyBhbmQgdGltZSAqLwo+ID4gIAltdm5l dGFfcnhfcGt0c19jb2FsX3NldChwcCwgcnhxLCByeHEtPnBrdHNfY29hbCk7Cj4gPiAgCW12bmV0 YV9yeF90aW1lX2NvYWxfc2V0KHBwLCByeHEsIHJ4cS0+dGltZV9jb2FsKTsKPiA+ICAKPiA+ICAJ aWYgKCFwcC0+Ym1fcHJpdikgewo+ID4gLQkJLyogU2V0IE9mZnNldCAqLwo+ID4gLQkJbXZuZXRh X3J4cV9vZmZzZXRfc2V0KHBwLCByeHEsIDApOwo+ID4gIAkJbXZuZXRhX3J4cV9idWZfc2l6ZV9z ZXQocHAsIHJ4cSwgcHAtPmZyYWdfc2l6ZSk7Cj4gPiAgCQltdm5ldGFfcnhxX2JtX2Rpc2FibGUo cHAsIHJ4cSk7Cj4gPiAgCQltdm5ldGFfcnhxX2ZpbGwocHAsIHJ4cSwgcnhxLT5zaXplKTsKPiA+ ICAJfSBlbHNlIHsKPiA+IC0JCS8qIFNldCBPZmZzZXQgKi8KPiA+IC0JCW12bmV0YV9yeHFfb2Zm c2V0X3NldChwcCwgcnhxLAo+ID4gLQkJCQkgICAgICBORVRfU0tCX1BBRCAtIHBwLT5yeF9vZmZz ZXRfY29ycmVjdGlvbik7Cj4gPiAtCj4gPiAgCQltdm5ldGFfcnhxX2JtX2VuYWJsZShwcCwgcnhx KTsKPiA+ICAJCS8qIEZpbGwgUlhRIHdpdGggYnVmZmVycyBmcm9tIFJYIHBvb2wgKi8KPiA+ICAJ CW12bmV0YV9yeHFfbG9uZ19wb29sX3NldChwcCwgcnhxKTsKPiA+IEBAIC00NTQ3LDcgKzQ1NDQs MTMgQEAgc3RhdGljIGludCBtdm5ldGFfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikKPiA+ICAJU0VUX05FVERFVl9ERVYoZGV2LCAmcGRldi0+ZGV2KTsKPiA+ICAKPiA+ICAJcHAt PmlkID0gZ2xvYmFsX3BvcnRfaWQrKzsKPiA+IC0JcHAtPnJ4X29mZnNldF9jb3JyZWN0aW9uID0g MDsgLyogbm90IHJlbGV2YW50IGZvciBTVyBCTSAqLwo+ID4gKwo+ID4gKwkvKiBTZXQgUlggcGFj a2V0IG9mZnNldCBjb3JyZWN0aW9uIGZvciBwbGF0Zm9ybXMsIHdob3NlCj4gPiArCSAqIE5FVF9T S0JfUEFELCBleGNlZWRzIDY0Qi4gSXQgc2hvdWxkIGJlIDY0QiBmb3IgNjQtYml0Cj4gPiArCSAq IHBsYXRmb3JtcyBhbmQgMEIgZm9yIDMyLWJpdCBvbmVzLgo+ID4gKwkgKi8KPiA+ICsJcHAtPnJ4 X29mZnNldF9jb3JyZWN0aW9uID0KPiA+ICsJCW1heCgwLCBORVRfU0tCX1BBRCAtIE1WTkVUQV9S WF9QS1RfT0ZGU0VUX0NPUlJFQ1RJT04pOwo+ID4gIAo+ID4gIAkvKiBPYnRhaW4gYWNjZXNzIHRv IEJNIHJlc291cmNlcyBpZiBlbmFibGVkIGFuZCBhbHJlYWR5IGluaXRpYWxpemVkICovCj4gPiAg CWJtX25vZGUgPSBvZl9wYXJzZV9waGFuZGxlKGRuLCAiYnVmZmVyLW1hbmFnZXIiLCAwKTsKPiA+ IEBAIC00NTYyLDEzICs0NTY1LDYgQEAgc3RhdGljIGludCBtdm5ldGFfcHJvYmUoc3RydWN0IHBs YXRmb3JtX2RldmljZSAqcGRldikKPiA+ICAJCQkJcHAtPmJtX3ByaXYgPSBOVUxMOwo+ID4gIAkJ CX0KPiA+ICAJCX0KPiA+IC0JCS8qIFNldCBSWCBwYWNrZXQgb2Zmc2V0IGNvcnJlY3Rpb24gZm9y IHBsYXRmb3Jtcywgd2hvc2UKPiA+IC0JCSAqIE5FVF9TS0JfUEFELCBleGNlZWRzIDY0Qi4gSXQg c2hvdWxkIGJlIDY0QiBmb3IgNjQtYml0Cj4gPiAtCQkgKiBwbGF0Zm9ybXMgYW5kIDBCIGZvciAz Mi1iaXQgb25lcy4KPiA+IC0JCSAqLwo+ID4gLQkJcHAtPnJ4X29mZnNldF9jb3JyZWN0aW9uID0g bWF4KDAsCj4gPiAtCQkJCQkgICAgICAgTkVUX1NLQl9QQUQgLQo+ID4gLQkJCQkJICAgICAgIE1W TkVUQV9SWF9QS1RfT0ZGU0VUX0NPUlJFQ1RJT04pOwo+ID4gIAl9Cj4gPiAgCW9mX25vZGVfcHV0 KGJtX25vZGUpOwo+ID4gIAo+ID4gLS0gCj4gPiAyLjE4LjAKPiA+ICAKPiAKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==