From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: [RFC PATCH] bpf: test case for kcm + sockmap Date: Thu, 30 Aug 2018 15:39:47 -0700 Message-ID: <20180830223555.11553.24093.stgit@john-Precision-Tower-5810> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: ast@kernel.org, daniel@iogearbox.net Return-path: Received: from [184.63.162.180] ([184.63.162.180]:47758 "EHLO john-Precision-Tower-5810" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725836AbeHaCoQ (ORCPT ); Thu, 30 Aug 2018 22:44:16 -0400 Sender: netdev-owner@vger.kernel.org List-ID: This finds the issue with kcm and sockmap where when a kcm socket is added to a sockmap we fail to notice it is a kcm sock and not a tcp bpf ULP sock. This results in a refcount_inc_not_zero() being called on the psock which is assigned to a smap_psock incorrectly. On my system it just happens to fail there and returns EAGAIN. With the fix, just submitted for bpf tree, we get the correct EBUSY error. https://patchwork.ozlabs.org/project/netdev/list/?series=63393 RFC for now and will submit properly when bpf fix makes its way into bpf-next. But, wanted to get the test on the list for folks to look at. --- John Fastabend (1): bpf: test_maps add a test to catch kcm + sockmap tools/testing/selftests/bpf/Makefile | 2 - tools/testing/selftests/bpf/test_maps.c | 64 ++++++++++++++++++++++++++++++- 2 files changed, 63 insertions(+), 3 deletions(-)