From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types Date: Fri, 31 Aug 2018 10:45:32 +0200 Message-ID: <20180831104532.22093b6d@cakuba.netronome.com> References: <20180831063242.9532-1-bhole_prashant_q7@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Alexei Starovoitov , Daniel Borkmann , Quentin Monnet , netdev@vger.kernel.org To: Prashant Bhole Return-path: Received: from mail-pl1-f193.google.com ([209.85.214.193]:35973 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727202AbeHaMwE (ORCPT ); Fri, 31 Aug 2018 08:52:04 -0400 Received: by mail-pl1-f193.google.com with SMTP id e11-v6so5173677plb.3 for ; Fri, 31 Aug 2018 01:45:40 -0700 (PDT) In-Reply-To: <20180831063242.9532-1-bhole_prashant_q7@lab.ntt.co.jp> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 31 Aug 2018 15:32:42 +0900, Prashant Bhole wrote: > When listed all maps, bpftool currently shows (null) for xskmap. > Added xskmap type in map_type_name[] to show correct type. > > Signed-off-by: Prashant Bhole Acked-by: Jakub Kicinski Thank you! I feel tempted to suggest considering the bpf tree, but perhaps that's a stretch.. > diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c > index df175bc33c5d..9c55077ca5dd 100644 > --- a/tools/bpf/bpftool/map.c > +++ b/tools/bpf/bpftool/map.c > @@ -68,6 +68,7 @@ static const char * const map_type_name[] = { > [BPF_MAP_TYPE_DEVMAP] = "devmap", > [BPF_MAP_TYPE_SOCKMAP] = "sockmap", > [BPF_MAP_TYPE_CPUMAP] = "cpumap", > + [BPF_MAP_TYPE_XSKMAP] = "xskmap", > [BPF_MAP_TYPE_SOCKHASH] = "sockhash", > [BPF_MAP_TYPE_CGROUP_STORAGE] = "cgroup_storage", > };