From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Manlunas Subject: Re: [PATCH v2 net-next] liquidio: remove set but not used variable 'irh' Date: Fri, 31 Aug 2018 13:16:59 -0700 Message-ID: <20180831201659.GA1288@felix-thinkpad.cavium.com> References: <1535716436-87194-1-git-send-email-yuehaibing@huawei.com> <1535717036-88514-1-git-send-email-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Derek Chickles , Satanand Burla , Felix Manlunas , Raghu Vatsavayi , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: YueHaibing Return-path: Received: from mail-by2nam03on0064.outbound.protection.outlook.com ([104.47.42.64]:29280 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727085AbeIAA0L (ORCPT ); Fri, 31 Aug 2018 20:26:11 -0400 Content-Disposition: inline In-Reply-To: <1535717036-88514-1-git-send-email-yuehaibing@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Aug 31, 2018 at 12:03:56PM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/cavium/liquidio/request_manager.c: In function 'lio_process_iq_request_list': > drivers/net/ethernet/cavium/liquidio/request_manager.c:383:27: warning: > variable 'irh' set but not used [-Wunused-but-set-variable] > > Signed-off-by: YueHaibing > --- > v2: fix patch description,remove 'cHECK-' > --- > drivers/net/ethernet/cavium/liquidio/request_manager.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c > index bd0153e..c6f4cbd 100644 > --- a/drivers/net/ethernet/cavium/liquidio/request_manager.c > +++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c > @@ -380,7 +380,6 @@ static inline void __copy_cmd_into_iq(struct octeon_instr_queue *iq, > u32 inst_count = 0; > unsigned int pkts_compl = 0, bytes_compl = 0; > struct octeon_soft_command *sc; > - struct octeon_instr_irh *irh; > unsigned long flags; > > while (old != iq->octeon_read_index) { > @@ -402,14 +401,6 @@ static inline void __copy_cmd_into_iq(struct octeon_instr_queue *iq, > case REQTYPE_RESP_NET: > case REQTYPE_SOFT_COMMAND: > sc = buf; > - > - if (OCTEON_CN23XX_PF(oct) || OCTEON_CN23XX_VF(oct)) > - irh = (struct octeon_instr_irh *) > - &sc->cmd.cmd3.irh; > - else > - irh = (struct octeon_instr_irh *) > - &sc->cmd.cmd2.irh; > - > /* We're expecting a response from Octeon. > * It's up to lio_process_ordered_list() to > * process sc. Add sc to the ordered soft > Acked-by: Felix Manlunas