From: David Miller <davem@davemloft.net>
To: florent.fourcot@wifirst.fr
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net/sched: fix type of htb statistics
Date: Sun, 02 Sep 2018 13:57:47 -0700 (PDT) [thread overview]
Message-ID: <20180902.135747.17420539327356406.davem@davemloft.net> (raw)
In-Reply-To: <20180830143923.25122-1-florent.fourcot@wifirst.fr>
From: Florent Fourcot <florent.fourcot@wifirst.fr>
Date: Thu, 30 Aug 2018 16:39:23 +0200
> tokens and ctokens are defined as s64 in htb_class structure,
> and clamped to 32bits value during netlink dumps:
>
> cl->xstats.tokens = clamp_t(s64, PSCHED_NS2TICKS(cl->tokens),
> INT_MIN, INT_MAX);
>
> Defining it as u32 is working since userspace (tc) is printing it as
> signed int, but a correct definition from the beginning is probably
> better.
>
> In the same time, 'giants' structure member is unused since years, so
> update the comment to mark it unused.
>
> Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
Looks good, applied.
prev parent reply other threads:[~2018-09-03 1:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 14:39 [PATCH net-next] net/sched: fix type of htb statistics Florent Fourcot
2018-09-02 20:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180902.135747.17420539327356406.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=florent.fourcot@wifirst.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).