From: David Miller <davem@davemloft.net>
To: baijiaju1990@gmail.com
Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: cadence: Fix a sleep-in-atomic-context bug in macb_halt_tx()
Date: Sun, 02 Sep 2018 16:05:38 -0700 (PDT) [thread overview]
Message-ID: <20180902.160538.1996490624543458172.davem@davemloft.net> (raw)
In-Reply-To: <20180901121105.436-1-baijiaju1990@gmail.com>
From: Jia-Ju Bai <baijiaju1990@gmail.com>
Date: Sat, 1 Sep 2018 20:11:05 +0800
> The kernel module may sleep with holding a spinlock.
>
> The function call paths (from bottom to top) in Linux-4.16 are:
>
> [FUNC] usleep_range
> drivers/net/ethernet/cadence/macb_main.c, 648:
> usleep_range in macb_halt_tx
> drivers/net/ethernet/cadence/macb_main.c, 730:
> macb_halt_tx in macb_tx_error_task
> drivers/net/ethernet/cadence/macb_main.c, 721:
> _raw_spin_lock_irqsave in macb_tx_error_task
>
> To fix this bug, usleep_range() is replaced with udelay().
>
> This bug is found by my static analysis tool DSAC.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2018-09-02 23:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-01 12:11 [PATCH] net: cadence: Fix a sleep-in-atomic-context bug in macb_halt_tx() Jia-Ju Bai
2018-09-02 23:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180902.160538.1996490624543458172.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=baijiaju1990@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).