From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] tcp: remove useless add operation when init sysctl_max_tw_buckets Date: Sun, 02 Sep 2018 16:13:16 -0700 (PDT) Message-ID: <20180902.161316.1787939948176707232.davem@davemloft.net> References: <1535804465-11795-1-git-send-email-laoar.shao@gmail.com> <1535804465-11795-2-git-send-email-laoar.shao@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: laoar.shao@gmail.com Return-path: In-Reply-To: <1535804465-11795-2-git-send-email-laoar.shao@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Yafang Shao Date: Sat, 1 Sep 2018 20:21:05 +0800 > cp_hashinfo.ehash_mask is always an odd number, which is set in function > alloc_large_system_hash(). See bellow, > if (_hash_mask) > *_hash_mask = (1 << log2qty) - 1; <<< always odd number > > Hence the local variable 'cnt' is a even number, as a result of that it is > no difference to do the incrementation here. > > Signed-off-by: Yafang Shao Applied.