From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition Date: Mon, 03 Sep 2018 21:23:43 -0700 (PDT) Message-ID: <20180903.212343.355534384554181027.davem@davemloft.net> References: <20180903222127-mutt-send-email-mst@kernel.org> <20180903231102-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Cc: jasowang@redhat.com, glebfm@altlinux.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: mst@redhat.com Return-path: In-Reply-To: <20180903231102-mutt-send-email-mst@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: "Michael S. Tsirkin" Date: Mon, 3 Sep 2018 23:11:11 -0400 > On Tue, Sep 04, 2018 at 11:08:40AM +0800, Jason Wang wrote: >> >> >> On 2018年09月04日 10:22, Michael S. Tsirkin wrote: >> > On Mon, Sep 03, 2018 at 08:59:13PM +0300, Gleb Fotengauer-Malinovskiy wrote: >> > > The _IOC_READ flag fits this ioctl request more because this request >> > > actually only writes to, but doesn't read from userspace. >> > > See NOTEs in include/uapi/asm-generic/ioctl.h for more information. >> > > >> > > Fixes: 429711aec282 ("vhost: switch to use new message format") >> > > Signed-off-by: Gleb Fotengauer-Malinovskiy >> > Hmm it does make sense, and it's not too late to fix this up. >> > Jason, what's your take on this? Was _IOW intentional? >> >> My bad, not intentional. And I agree that fixing this is not too late. >> >> So >> >> Acked-by: Jason Wang > > > OK then > > Acked-by: Michael S. Tsirkin Applied, thanks everyone.