* [PATCH] vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition
@ 2018-09-03 17:59 Gleb Fotengauer-Malinovskiy
2018-09-04 2:22 ` Michael S. Tsirkin
0 siblings, 1 reply; 5+ messages in thread
From: Gleb Fotengauer-Malinovskiy @ 2018-09-03 17:59 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, David S. Miller, kvm,
virtualization, netdev, linux-kernel
The _IOC_READ flag fits this ioctl request more because this request
actually only writes to, but doesn't read from userspace.
See NOTEs in include/uapi/asm-generic/ioctl.h for more information.
Fixes: 429711aec282 ("vhost: switch to use new message format")
Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
---
include/uapi/linux/vhost.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
index b1e22c40c4b6..84c3de89696a 100644
--- a/include/uapi/linux/vhost.h
+++ b/include/uapi/linux/vhost.h
@@ -176,7 +176,7 @@ struct vhost_memory {
#define VHOST_BACKEND_F_IOTLB_MSG_V2 0x1
#define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64)
-#define VHOST_GET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x26, __u64)
+#define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64)
/* VHOST_NET specific defines */
--
glebfm
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition
2018-09-03 17:59 [PATCH] vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition Gleb Fotengauer-Malinovskiy
@ 2018-09-04 2:22 ` Michael S. Tsirkin
2018-09-04 3:08 ` Jason Wang
0 siblings, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2018-09-04 2:22 UTC (permalink / raw)
To: Gleb Fotengauer-Malinovskiy
Cc: kvm, netdev, linux-kernel, virtualization, David S. Miller
On Mon, Sep 03, 2018 at 08:59:13PM +0300, Gleb Fotengauer-Malinovskiy wrote:
> The _IOC_READ flag fits this ioctl request more because this request
> actually only writes to, but doesn't read from userspace.
> See NOTEs in include/uapi/asm-generic/ioctl.h for more information.
>
> Fixes: 429711aec282 ("vhost: switch to use new message format")
> Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
Hmm it does make sense, and it's not too late to fix this up.
Jason, what's your take on this? Was _IOW intentional?
> ---
> include/uapi/linux/vhost.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
> index b1e22c40c4b6..84c3de89696a 100644
> --- a/include/uapi/linux/vhost.h
> +++ b/include/uapi/linux/vhost.h
> @@ -176,7 +176,7 @@ struct vhost_memory {
> #define VHOST_BACKEND_F_IOTLB_MSG_V2 0x1
>
> #define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64)
> -#define VHOST_GET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x26, __u64)
> +#define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64)
>
> /* VHOST_NET specific defines */
>
>
> --
> glebfm
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition
2018-09-04 2:22 ` Michael S. Tsirkin
@ 2018-09-04 3:08 ` Jason Wang
2018-09-04 3:11 ` Michael S. Tsirkin
0 siblings, 1 reply; 5+ messages in thread
From: Jason Wang @ 2018-09-04 3:08 UTC (permalink / raw)
To: Michael S. Tsirkin, Gleb Fotengauer-Malinovskiy
Cc: David S. Miller, kvm, virtualization, netdev, linux-kernel
On 2018年09月04日 10:22, Michael S. Tsirkin wrote:
> On Mon, Sep 03, 2018 at 08:59:13PM +0300, Gleb Fotengauer-Malinovskiy wrote:
>> The _IOC_READ flag fits this ioctl request more because this request
>> actually only writes to, but doesn't read from userspace.
>> See NOTEs in include/uapi/asm-generic/ioctl.h for more information.
>>
>> Fixes: 429711aec282 ("vhost: switch to use new message format")
>> Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
> Hmm it does make sense, and it's not too late to fix this up.
> Jason, what's your take on this? Was _IOW intentional?
My bad, not intentional. And I agree that fixing this is not too late.
So
Acked-by: Jason Wang <jasowang@redhat.com>
>
>> ---
>> include/uapi/linux/vhost.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
>> index b1e22c40c4b6..84c3de89696a 100644
>> --- a/include/uapi/linux/vhost.h
>> +++ b/include/uapi/linux/vhost.h
>> @@ -176,7 +176,7 @@ struct vhost_memory {
>> #define VHOST_BACKEND_F_IOTLB_MSG_V2 0x1
>>
>> #define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64)
>> -#define VHOST_GET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x26, __u64)
>> +#define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64)
>>
>> /* VHOST_NET specific defines */
>>
>>
>> --
>> glebfm
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition
2018-09-04 3:08 ` Jason Wang
@ 2018-09-04 3:11 ` Michael S. Tsirkin
2018-09-04 4:23 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2018-09-04 3:11 UTC (permalink / raw)
To: Jason Wang
Cc: Gleb Fotengauer-Malinovskiy, David S. Miller, kvm, virtualization,
netdev, linux-kernel
On Tue, Sep 04, 2018 at 11:08:40AM +0800, Jason Wang wrote:
>
>
> On 2018年09月04日 10:22, Michael S. Tsirkin wrote:
> > On Mon, Sep 03, 2018 at 08:59:13PM +0300, Gleb Fotengauer-Malinovskiy wrote:
> > > The _IOC_READ flag fits this ioctl request more because this request
> > > actually only writes to, but doesn't read from userspace.
> > > See NOTEs in include/uapi/asm-generic/ioctl.h for more information.
> > >
> > > Fixes: 429711aec282 ("vhost: switch to use new message format")
> > > Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
> > Hmm it does make sense, and it's not too late to fix this up.
> > Jason, what's your take on this? Was _IOW intentional?
>
> My bad, not intentional. And I agree that fixing this is not too late.
>
> So
>
> Acked-by: Jason Wang <jasowang@redhat.com>
OK then
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > > ---
> > > include/uapi/linux/vhost.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
> > > index b1e22c40c4b6..84c3de89696a 100644
> > > --- a/include/uapi/linux/vhost.h
> > > +++ b/include/uapi/linux/vhost.h
> > > @@ -176,7 +176,7 @@ struct vhost_memory {
> > > #define VHOST_BACKEND_F_IOTLB_MSG_V2 0x1
> > > #define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64)
> > > -#define VHOST_GET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x26, __u64)
> > > +#define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64)
> > > /* VHOST_NET specific defines */
> > >
> > > --
> > > glebfm
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition
2018-09-04 3:11 ` Michael S. Tsirkin
@ 2018-09-04 4:23 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2018-09-04 4:23 UTC (permalink / raw)
To: mst; +Cc: jasowang, glebfm, kvm, virtualization, netdev, linux-kernel
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Mon, 3 Sep 2018 23:11:11 -0400
> On Tue, Sep 04, 2018 at 11:08:40AM +0800, Jason Wang wrote:
>>
>>
>> On 2018年09月04日 10:22, Michael S. Tsirkin wrote:
>> > On Mon, Sep 03, 2018 at 08:59:13PM +0300, Gleb Fotengauer-Malinovskiy wrote:
>> > > The _IOC_READ flag fits this ioctl request more because this request
>> > > actually only writes to, but doesn't read from userspace.
>> > > See NOTEs in include/uapi/asm-generic/ioctl.h for more information.
>> > >
>> > > Fixes: 429711aec282 ("vhost: switch to use new message format")
>> > > Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
>> > Hmm it does make sense, and it's not too late to fix this up.
>> > Jason, what's your take on this? Was _IOW intentional?
>>
>> My bad, not intentional. And I agree that fixing this is not too late.
>>
>> So
>>
>> Acked-by: Jason Wang <jasowang@redhat.com>
>
>
> OK then
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-04 4:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-03 17:59 [PATCH] vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition Gleb Fotengauer-Malinovskiy
2018-09-04 2:22 ` Michael S. Tsirkin
2018-09-04 3:08 ` Jason Wang
2018-09-04 3:11 ` Michael S. Tsirkin
2018-09-04 4:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).