From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: vladbu@mellanox.com, netdev@vger.kernel.org, jhs@mojatatu.com,
jiri@resnulli.us
Subject: Re: [PATCH net-next] net: sched: null actions array pointer before releasing action
Date: Mon, 03 Sep 2018 21:47:54 -0700 (PDT) [thread overview]
Message-ID: <20180903.214754.1769188450969981251.davem@davemloft.net> (raw)
In-Reply-To: <CAM_iQpU+3O1oxTPg2D6_O-FxuEMjWYZjaHrBEzg5Jy5=3=Nq6A@mail.gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Mon, 3 Sep 2018 11:18:43 -0700
> On Mon, Sep 3, 2018 at 12:05 AM Vlad Buslov <vladbu@mellanox.com> wrote:
>>
>> Currently, tcf_action_delete() nulls actions array pointer after putting
>> and deleting it. However, if tcf_idr_delete_index() returns an error,
>> pointer to action is not set to null. That results it being released second
>> time in error handling code of tca_action_gd().
>
> Oops, good catch.
>
> Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
>
> David, this one should also go to -net rather than -net-next.
Applied to 'net', thanks.
prev parent reply other threads:[~2018-09-04 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 7:04 [PATCH net-next] net: sched: null actions array pointer before releasing action Vlad Buslov
2018-09-03 18:18 ` Cong Wang
2018-09-04 4:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903.214754.1769188450969981251.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=vladbu@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).