From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] net: sched: null actions array pointer before
 releasing action
Date: Mon, 03 Sep 2018 21:47:54 -0700 (PDT)
Message-ID: <20180903.214754.1769188450969981251.davem@davemloft.net>
References: <1535958295-6697-1-git-send-email-vladbu@mellanox.com>
        <CAM_iQpU+3O1oxTPg2D6_O-FxuEMjWYZjaHrBEzg5Jy5=3=Nq6A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: vladbu@mellanox.com, netdev@vger.kernel.org, jhs@mojatatu.com,
        jiri@resnulli.us
To: xiyou.wangcong@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:51030 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726344AbeIDJLO (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 4 Sep 2018 05:11:14 -0400
In-Reply-To: <CAM_iQpU+3O1oxTPg2D6_O-FxuEMjWYZjaHrBEzg5Jy5=3=Nq6A@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Mon, 3 Sep 2018 11:18:43 -0700

> On Mon, Sep 3, 2018 at 12:05 AM Vlad Buslov <vladbu@mellanox.com> wrote:
>>
>> Currently, tcf_action_delete() nulls actions array pointer after putting
>> and deleting it. However, if tcf_idr_delete_index() returns an error,
>> pointer to action is not set to null. That results it being released second
>> time in error handling code of tca_action_gd().
> 
> Oops, good catch.
> 
> Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
> 
> David, this one should also go to -net rather than -net-next.

Applied to 'net', thanks.