From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 09/12] net: ethernet: Add helper for MACs which
 support pause
Date: Mon, 3 Sep 2018 21:54:10 +0200
Message-ID: <20180903195410.GH4445@lunn.ch>
References: <1535908001-18593-1-git-send-email-andrew@lunn.ch>
 <1535908001-18593-10-git-send-email-andrew@lunn.ch>
 <83284fd9-db3e-4029-ca63-b316b224ac39@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>, maxime.chevallier@bootlin.com
To: Florian Fainelli <f.fainelli@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:51088 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728425AbeIDAP5 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 3 Sep 2018 20:15:57 -0400
Content-Disposition: inline
In-Reply-To: <83284fd9-db3e-4029-ca63-b316b224ac39@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Sep 03, 2018 at 10:39:04AM -0700, Florian Fainelli wrote:
> 
> 
> On 9/2/2018 10:06 AM, Andrew Lunn wrote:
> >Rather than have the MAC drivers manipulate phydev members, add a
> >helper function for MACs supporting Pause, but not Asym Pause.
> >
> >Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> 
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> I wonder if this would be better named phy_support_sym_pause() as opposed to
> asym_pause()?

Hi Florian

Maybe, bit it is then very similar to asym. I wounder if there is some
other word we can use for the symmetrical case?

      Andrew