From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition Date: Mon, 3 Sep 2018 22:22:37 -0400 Message-ID: <20180903222127-mutt-send-email-mst@kernel.org> References: <20180903175906.GA11529@glebfm.cloud.tilaa.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, "David S. Miller" To: Gleb Fotengauer-Malinovskiy Return-path: Content-Disposition: inline In-Reply-To: <20180903175906.GA11529@glebfm.cloud.tilaa.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Mon, Sep 03, 2018 at 08:59:13PM +0300, Gleb Fotengauer-Malinovskiy wrote: > The _IOC_READ flag fits this ioctl request more because this request > actually only writes to, but doesn't read from userspace. > See NOTEs in include/uapi/asm-generic/ioctl.h for more information. > > Fixes: 429711aec282 ("vhost: switch to use new message format") > Signed-off-by: Gleb Fotengauer-Malinovskiy Hmm it does make sense, and it's not too late to fix this up. Jason, what's your take on this? Was _IOW intentional? > --- > include/uapi/linux/vhost.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h > index b1e22c40c4b6..84c3de89696a 100644 > --- a/include/uapi/linux/vhost.h > +++ b/include/uapi/linux/vhost.h > @@ -176,7 +176,7 @@ struct vhost_memory { > #define VHOST_BACKEND_F_IOTLB_MSG_V2 0x1 > > #define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64) > -#define VHOST_GET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x26, __u64) > +#define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64) > > /* VHOST_NET specific defines */ > > > -- > glebfm