From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net/mlx5: Fix SQ offset in QPs with small RQ Date: Tue, 04 Sep 2018 12:18:03 -0700 (PDT) Message-ID: <20180904.121803.2062697287279067455.davem@davemloft.net> References: <1535987184-16417-1-git-send-email-tariqt@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, eranbe@mellanox.com, saeedm@mellanox.com, alaa@mellanox.com To: tariqt@mellanox.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:33340 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727586AbeIDXod (ORCPT ); Tue, 4 Sep 2018 19:44:33 -0400 In-Reply-To: <1535987184-16417-1-git-send-email-tariqt@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Tariq Toukan Date: Mon, 3 Sep 2018 18:06:24 +0300 > Correct the formula for calculating the RQ page remainder, > which should be in byte granularity. The result will be > non-zero only for RQs smaller than PAGE_SIZE, as an RQ size > is a power of 2. > > Divide this by the SQ stride (MLX5_SEND_WQE_BB) to get the > SQ offset in strides granularity. > > Fixes: d7037ad73daa ("net/mlx5: Fix QP fragmented buffer allocation") > Signed-off-by: Tariq Toukan > Reviewed-by: Eran Ben Elisha > Signed-off-by: Saeed Mahameed > --- > drivers/net/ethernet/mellanox/mlx5/core/wq.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > Hi Dave, > Please queue for -stable v4.18. Applied and queued up for -stable, thanks.