From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net] act_ife: fix a potential use-after-free Date: Tue, 04 Sep 2018 12:19:06 -0700 (PDT) Message-ID: <20180904.121906.91139500169468204.davem@davemloft.net> References: <20180903180815.32220-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jhs@mojatatu.com To: xiyou.wangcong@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:33362 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727765AbeIDXph (ORCPT ); Tue, 4 Sep 2018 19:45:37 -0400 In-Reply-To: <20180903180815.32220-1-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Cong Wang Date: Mon, 3 Sep 2018 11:08:15 -0700 > Immediately after module_put(), user could delete this > module, so e->ops could be already freed before we call > e->ops->release(). > > Fix this by moving module_put() after ops->release(). > > Fixes: ef6980b6becb ("introduce IFE action") > Signed-off-by: Cong Wang Applied and queued up for -stable, thanks Cong.