netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vladbu@mellanox.com
Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com,
	jhs@mojatatu.com, jiri@resnulli.us
Subject: Re: [PATCH net-next v2] net: sched: action_ife: take reference to meta module
Date: Tue, 04 Sep 2018 12:21:43 -0700 (PDT)	[thread overview]
Message-ID: <20180904.122143.357979347828802599.davem@davemloft.net> (raw)
In-Reply-To: <1536011082-2043-1-git-send-email-vladbu@mellanox.com>

From: Vlad Buslov <vladbu@mellanox.com>
Date: Tue,  4 Sep 2018 00:44:42 +0300

> Recent refactoring of add_metainfo() caused use_all_metadata() to add
> metainfo to ife action metalist without taking reference to module. This
> causes warning in module_put called from ife action cleanup function.
> 
> Implement add_metainfo_and_get_ops() function that returns with reference
> to module taken if metainfo was added successfully, and call it from
> use_all_metadata(), instead of calling __add_metainfo() directly.
> 
> Example warning:
 ...
> Fixes: 5ffe57da29b3 ("act_ife: fix a potential deadlock")
> Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
> ---
> 
> Changes V1->V2:
> - fold constants into helper function

Applied to 'net'.

      parent reply	other threads:[~2018-09-04 23:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03  7:10 [PATCH net-next] net: sched: action_ife: take reference to meta module Vlad Buslov
2018-09-03 17:03 ` Cong Wang
2018-09-03 17:11   ` Vlad Buslov
2018-09-03 17:36     ` Cong Wang
2018-09-03 17:43 ` Cong Wang
2018-09-03 21:44   ` [PATCH net-next v2] " Vlad Buslov
2018-09-04 18:32     ` Cong Wang
2018-09-04 19:21     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180904.122143.357979347828802599.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=vladbu@mellanox.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).