From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: phy: sfp: Handle unimplemented hwmon limits and alarms Date: Tue, 04 Sep 2018 12:23:15 -0700 (PDT) Message-ID: <20180904.122315.1164590585525043783.davem@davemloft.net> References: <1536027836-19913-1-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, rmk+kernel@arm.linux.org.uk, f.fainelli@gmail.com To: andrew@lunn.ch Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:33406 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727586AbeIDXtq (ORCPT ); Tue, 4 Sep 2018 19:49:46 -0400 In-Reply-To: <1536027836-19913-1-git-send-email-andrew@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: From: Andrew Lunn Date: Tue, 4 Sep 2018 04:23:56 +0200 > Not all SFPs implement the registers containing sensor limits and > alarms. Luckily, there is a bit indicating if they are implemented or > not. Add checking for this bit, when deciding if the hwmon attributes > should be visible. > > Fixes: 1323061a018a ("net: phy: sfp: Add HWMON support for module sensors") > Signed-off-by: Andrew Lunn Applied, thanks Andrew.