From: David Miller <davem@davemloft.net>
To: petrm@mellanox.com
Cc: netdev@vger.kernel.org, jiri@mellanox.com, idosch@mellanox.com
Subject: Re: [PATCH net] mlxsw: spectrum_buffers: Set up a dedicated pool for BUM traffic
Date: Wed, 05 Sep 2018 07:56:19 -0700 (PDT) [thread overview]
Message-ID: <20180905.075619.663023561756737629.davem@davemloft.net> (raw)
In-Reply-To: <e6061a9fa329ba8de7663a9c1be4ece3b2c4100b.1536142130.git.petrm@mellanox.com>
From: Petr Machata <petrm@mellanox.com>
Date: Wed, 05 Sep 2018 12:16:00 +0200
> MC-aware mode was recently enabled by mlxsw on Spectrum switches in
> commit 7b8195306694 ("mlxsw: spectrum: Configure MC-aware mode on mlxsw
> ports"). Unfortunately, testing has shown that the fix is incomplete and
> in the presented form actually makes the problem even worse, because any
> amount of MC traffic causes UC disruption.
>
> The reason for this is that currently, mlxsw configures the MC-specific
> TCs (8..15) to map to pool 0. It also configures a maximum buffer size
> of 0, but for MC traffic that maximum is disregarded and not part of the
> quota. Therefore MC traffic is always admitted to the egress buffer.
>
> Fix the configuration by directing the MC TCs into pool 15, which is
> dedicated to MC traffic and recognized as such by the silicon.
>
> Fixes: 7b8195306694 ("mlxsw: spectrum: Configure MC-aware mode on mlxsw ports")
> Signed-off-by: Petr Machata <petrm@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
Applied, thank you.
prev parent reply other threads:[~2018-09-05 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 10:16 [PATCH net] mlxsw: spectrum_buffers: Set up a dedicated pool for BUM traffic Petr Machata
2018-09-05 14:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905.075619.663023561756737629.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).