From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net] tipc: orphan sock in tipc_release() Date: Wed, 05 Sep 2018 22:15:04 -0700 (PDT) Message-ID: <20180905.221504.1007617876680290112.davem@davemloft.net> References: <20180904021241.11426-1-xiyou.wangcong@gmail.com> <20180904021241.11426-2-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, jon.maloy@ericsson.com, ying.xue@windriver.com To: xiyou.wangcong@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:55466 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbeIFJso (ORCPT ); Thu, 6 Sep 2018 05:48:44 -0400 In-Reply-To: <20180904021241.11426-2-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Cong Wang Date: Mon, 3 Sep 2018 19:12:41 -0700 > Before we unlock the sock in tipc_release(), we have to > detach sk->sk_socket from sk, otherwise a parallel > tipc_sk_fill_sock_diag() could stil read it after we > free this socket. > > Fixes: c30b70deb5f4 ("tipc: implement socket diagnostics for AF_TIPC") > Reported-and-tested-by: syzbot+48804b87c16588ad491d@syzkaller.appspotmail.com > Cc: Jon Maloy > Cc: Ying Xue > Signed-off-by: Cong Wang Applied and queued up for -stable, thanks.