From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2 net-next] failover: Add missing check to validate
 'slave_dev' in net_failover_slave_unregister
Date: Wed, 05 Sep 2018 22:16:28 -0700 (PDT)
Message-ID: <20180905.221628.2291238274171893981.davem@davemloft.net>
References: <1535771205-156540-1-git-send-email-yuehaibing@huawei.com>
        <1536029786-21710-1-git-send-email-yuehaibing@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: sridhar.samudrala@intel.com, stephen@networkplumber.org,
        dan.carpenter@oracle.com, alexander.h.duyck@intel.com,
        jeffrey.t.kirsher@intel.com, liran.alon@oracle.com,
        joao.m.martins@oracle.com, netdev@vger.kernel.org,
        kernel-janitors@vger.kernel.org
To: yuehaibing@huawei.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:55476 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725850AbeIFJuI (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 6 Sep 2018 05:50:08 -0400
In-Reply-To: <1536029786-21710-1-git-send-email-yuehaibing@huawei.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 4 Sep 2018 02:56:26 +0000

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/net_failover.c: In function 'net_failover_slave_unregister':
> drivers/net/net_failover.c:598:35: warning:
>  variable 'primary_dev' set but not used [-Wunused-but-set-variable]
> 
> There should check the validity of 'slave_dev'.
> 
> Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: use WARN_ON_ONCE as Liran Alon suggested

Applied.