From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support Date: Wed, 5 Sep 2018 02:06:28 +0200 Message-ID: <20180905000628.GM29121@lunn.ch> References: <20180904221120.13018-1-f.fainelli@gmail.com> <20180904221120.13018-6-f.fainelli@gmail.com> <20180904233222.GJ29121@lunn.ch> <57632a74-e3dd-893f-2573-d0450d6b290a@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, vivien.didelot@savoirfairelinux.com, davem@davemloft.net To: Florian Fainelli Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:52389 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbeIEEd7 (ORCPT ); Wed, 5 Sep 2018 00:33:59 -0400 Content-Disposition: inline In-Reply-To: <57632a74-e3dd-893f-2573-d0450d6b290a@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Sep 04, 2018 at 04:55:26PM -0700, Florian Fainelli wrote: > On 09/04/2018 04:32 PM, Andrew Lunn wrote: > > > > > >> +void b53_serdes_phylink_validate(struct b53_device *dev, int port, > >> + unsigned long *supported, > >> + struct phylink_link_state *state) > >> +{ > >> + u8 lane = b53_serdes_map_lane(dev, port); > >> + > >> + if (lane == B53_INVALID_LANE) > >> + return; > >> + > >> + switch (lane) { > >> + case 0: > >> + phylink_set(supported, 2500baseX_Full); > > > > Hi Florian > > > > Could you also use it for 2500BaseT_Full with an appropriate copper > > PHY? > > My reading of the datasheet (which only mentions 2.5G with no further > mention) make me think that is not possible to do copper at 2.5G and > only 2500baseX since it only talks about fiber and not copper. > > Would you recommend a specific SFP that allows that? Like this one: > > https://www.flexoptix.net/en/sfp-t-transceiver-2h-gigabit-cat-5e-rj-45-100m-100m-1000m-2500-base-t.html?co8829=85744 I was actually thinking of a 'plain old' copper PHY with a SERDES interface which can do 25000Base-T. The Marvell 88x3310 or the Aquantia 10G PHY, for example. Russell might be able to make a recommendation. I don't have any Copper SFP modules. Andrew