From: Andrew Lunn <andrew@lunn.ch>
To: Moritz Fischer <mdf@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
f.fainelli@gmail.com, alex.williams@ni.com,
moritz.fischer@ettus.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH] net: nixge: Add PHYLINK support
Date: Wed, 5 Sep 2018 03:01:00 +0200 [thread overview]
Message-ID: <20180905010100.GN29121@lunn.ch> (raw)
In-Reply-To: <20180905001535.19168-1-mdf@kernel.org>
> 3) I'm again not sure about the 'select PHYLINK', wouldn't
> wanna break the build again...
Hi Moritz
I think it is safe. PHYLINK has no stated dependencies on OF. But i
suspect it currently is pretty useless without OF.
> @@ -1286,7 +1329,13 @@ static int nixge_probe(struct platform_device *pdev)
> priv->coalesce_count_rx = XAXIDMA_DFT_RX_THRESHOLD;
> priv->coalesce_count_tx = XAXIDMA_DFT_TX_THRESHOLD;
>
> - err = nixge_mdio_setup(priv, pdev->dev.of_node);
> + mn = of_get_child_by_name(pdev->dev.of_node, "mdio");
> + if (!mn) {
> + dev_warn(&pdev->dev, "No \"mdio\" subnode found, defaulting to legacy\n");
> + mn = pdev->dev.of_node;
> + }
> +
> + err = nixge_mdio_setup(priv, mn);
I would suggest making this a patch of its own.
Also, do you need the legacy behaviour? If there are no boards out in
the wild which this will break, just make the change.
Please also update the device tree binding documentation.
Andrew
next prev parent reply other threads:[~2018-09-05 1:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 0:15 [RFC/PATCH] net: nixge: Add PHYLINK support Moritz Fischer
2018-09-05 0:27 ` Florian Fainelli
2018-09-05 4:05 ` Moritz Fischer
2018-09-05 12:31 ` Andrew Lunn
2018-09-06 16:36 ` Moritz Fischer
2018-09-05 1:01 ` Andrew Lunn [this message]
2018-09-05 3:27 ` Moritz Fischer
2018-09-05 1:07 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905010100.GN29121@lunn.ch \
--to=andrew@lunn.ch \
--cc=alex.williams@ni.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=moritz.fischer@ettus.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).