From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net-next 02/11] tuntap: switch to use XDP_PACKET_HEADROOM
Date: Thu, 6 Sep 2018 12:57:39 -0400 [thread overview]
Message-ID: <20180906125718-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180906040526.22518-3-jasowang@redhat.com>
On Thu, Sep 06, 2018 at 12:05:17PM +0800, Jason Wang wrote:
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
any idea why didn't we do this straight away?
> ---
> drivers/net/tun.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 2c548bd20393..d3677a544b56 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -113,7 +113,6 @@ do { \
> } while (0)
> #endif
>
> -#define TUN_HEADROOM 256
> #define TUN_RX_PAD (NET_IP_ALIGN + NET_SKB_PAD)
>
> /* TUN device flags */
> @@ -1654,7 +1653,7 @@ static struct sk_buff *tun_build_skb(struct tun_struct *tun,
> rcu_read_lock();
> xdp_prog = rcu_dereference(tun->xdp_prog);
> if (xdp_prog)
> - pad += TUN_HEADROOM;
> + pad += XDP_PACKET_HEADROOM;
> buflen += SKB_DATA_ALIGN(len + pad);
> rcu_read_unlock();
>
> --
> 2.17.1
next prev parent reply other threads:[~2018-09-06 16:57 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 4:05 [PATCH net-next 00/11] Vhost_net TX batching Jason Wang
2018-09-06 4:05 ` [PATCH net-next 01/11] net: sock: introduce SOCK_XDP Jason Wang
2018-09-06 16:56 ` Michael S. Tsirkin
2018-09-07 3:07 ` Jason Wang
2018-09-06 4:05 ` [PATCH net-next 02/11] tuntap: switch to use XDP_PACKET_HEADROOM Jason Wang
2018-09-06 16:57 ` Michael S. Tsirkin [this message]
2018-09-07 3:12 ` Jason Wang
2018-09-06 4:05 ` [PATCH net-next 03/11] tuntap: enable bh early during processing XDP Jason Wang
2018-09-06 17:02 ` Michael S. Tsirkin
2018-09-06 4:05 ` [PATCH net-next 04/11] tuntap: simplify error handling in tun_build_skb() Jason Wang
2018-09-06 17:14 ` Michael S. Tsirkin
2018-09-07 3:22 ` Jason Wang
2018-09-07 14:17 ` Michael S. Tsirkin
2018-09-10 3:44 ` Jason Wang
2018-09-06 4:05 ` [PATCH net-next 05/11] tuntap: tweak on the path of non-xdp case " Jason Wang
2018-09-06 17:16 ` Michael S. Tsirkin
2018-09-07 3:24 ` Jason Wang
2018-09-06 4:05 ` [PATCH net-next 06/11] tuntap: split out XDP logic Jason Wang
2018-09-06 17:21 ` Michael S. Tsirkin
2018-09-07 3:29 ` Jason Wang
2018-09-07 14:16 ` Michael S. Tsirkin
2018-09-10 3:43 ` Jason Wang
2018-09-06 4:05 ` [PATCH net-next 07/11] tuntap: move XDP flushing out of tun_do_xdp() Jason Wang
2018-09-06 17:48 ` Michael S. Tsirkin
2018-09-07 3:31 ` Jason Wang
2018-09-06 4:05 ` [PATCH net-next 08/11] tun: switch to new type of msg_control Jason Wang
2018-09-06 16:54 ` Michael S. Tsirkin
2018-09-07 3:35 ` Jason Wang
2018-09-06 4:05 ` [PATCH net-next 09/11] tuntap: accept an array of XDP buffs through sendmsg() Jason Wang
2018-09-06 17:51 ` Michael S. Tsirkin
2018-09-07 7:33 ` Jason Wang
2018-09-06 4:05 ` [PATCH net-next 10/11] tap: " Jason Wang
2018-09-06 18:00 ` Michael S. Tsirkin
2018-09-07 3:41 ` Jason Wang
2018-09-06 4:05 ` [PATCH net-next 11/11] vhost_net: batch submitting XDP buffers to underlayer sockets Jason Wang
2018-09-06 16:46 ` Michael S. Tsirkin
2018-09-07 7:41 ` Jason Wang
2018-09-07 16:13 ` Michael S. Tsirkin
2018-09-10 3:47 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906125718-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).