From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] wil6210: fix unsigned cid comparison with >= 0 Date: Thu, 6 Sep 2018 16:00:50 +0000 (UTC) Message-ID: <20180906160050.C81F76044E@smtp.codeaurora.org> References: <20180829175018.GA3776@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Maya Erez , "David S. Miller" , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, wil6210-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Gustavo A. R. Silva" To: "Gustavo A. R. Silva" Return-path: In-Reply-To: <20180829175018.GA3776-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org "Gustavo A. R. Silva" wrote: > The comparison of cid >= 0 is always true because cid is of type u8 > (8 bits, unsigned). > > Fix this by removing such comparison and updating the type of > variable cid to u8 in the caller function. > > Addresses-Coverity-ID: 1473079 ("Unsigned compared against 0") > Fixes: b9010f105f21 ("wil6210: add FT roam support for AP and station") > Signed-off-by: Gustavo A. R. Silva > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 49925f247016 wil6210: fix unsigned cid comparison with >= 0 -- https://patchwork.kernel.org/patch/10580739/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches