* [PATCH 1/1] ath10k: avoid possible memory access violation [not found] <CGME20180803104058epcas1p1d5cdd51e2774d72679aaf15358cb3d00@epcas1p1.samsung.com> @ 2018-08-03 10:40 ` K.T.VIJAYAKUMAAR [not found] ` <CGME20180803104058epcas1p1d5cdd51e2774d72679aaf15358cb3d00@epcms5p1> ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: K.T.VIJAYAKUMAAR @ 2018-08-03 10:40 UTC (permalink / raw) To: kvalo, davem, ath10k, linux-wireless, netdev, linux-kernel Cc: cpgs, vijay.bvb array "ctl_power_table" access index "pream" is initialized with -1 and is raised as a static analysis tool issue. [drivers\net\wireless\ath\ath10k\wmi.c:4719] -> [drivers\net\wireless\ath\ath10k\wmi.c:4730]: (error) Array index -1 is out of bounds. Since the "pream" index for accessing ctl_power_table array is initialized with -1, there is a chance of memory access violation for the cases below. 1) wmi_pdev_tpc_final_table_event change frequency is between 2483 and 5180 2) pream_idx is out of the enumeration ranges of wmi_tpc_pream_2ghz, wmi_tpc_pream_5ghz Signed-off-by: K.T.VIJAYAKUMAAR <vijay.bvb@samsung.com> --- drivers/net/wireless/ath/ath10k/wmi.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 877249a..23502cd 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -4721,6 +4721,13 @@ ath10k_wmi_tpc_final_get_rate(struct ath10k *ar, } } + if (pream == -1) { + ath10k_warn(ar, "unknown wmi tpc final: pream_idx[%u], chan_freq[%u]\n", + pream_idx, __le32_to_cpu(ev->chan_freq)); + tpc = 0; + goto out; + } + if (pream == 4) tpc = min_t(u8, ev->rates_array[rate_idx], ev->max_reg_allow_pow[ch]); -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <CGME20180803104058epcas1p1d5cdd51e2774d72679aaf15358cb3d00@epcms5p1>]
[parent not found: <20180810101916epcms5p1e3d60d9cbc49f9a7c9529d87d691f359@epcms5p1>]
* Re: [PATCH 1/1] ath10k: avoid possible memory access violation [not found] ` <20180810101916epcms5p1e3d60d9cbc49f9a7c9529d87d691f359@epcms5p1> @ 2018-08-10 12:03 ` Kalle Valo 0 siblings, 0 replies; 4+ messages in thread From: Kalle Valo @ 2018-08-10 12:03 UTC (permalink / raw) To: VIJAYAKUMAAR K T Cc: davem@davemloft.net, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, CPGS VIJAYAKUMAAR K T <vijay.bvb@samsung.com> writes: > It would be great, if this patch could be reviewed. It's in the queue and you can check the state from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork -- Kalle Valo ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ath10k: avoid possible memory access violation 2018-08-03 10:40 ` [PATCH 1/1] ath10k: avoid possible memory access violation K.T.VIJAYAKUMAAR [not found] ` <CGME20180803104058epcas1p1d5cdd51e2774d72679aaf15358cb3d00@epcms5p1> @ 2018-09-06 16:04 ` Kalle Valo 2018-09-06 16:04 ` Kalle Valo 2 siblings, 0 replies; 4+ messages in thread From: Kalle Valo @ 2018-09-06 16:04 UTC (permalink / raw) To: K.T.VIJAYAKUMAAR Cc: netdev, linux-wireless, linux-kernel, ath10k, cpgs, vijay.bvb, davem "K.T.VIJAYAKUMAAR" <vijay.bvb@samsung.com> wrote: > array "ctl_power_table" access index "pream" is initialized with -1 and > is raised as a static analysis tool issue. > [drivers\net\wireless\ath\ath10k\wmi.c:4719] -> > [drivers\net\wireless\ath\ath10k\wmi.c:4730]: (error) Array index -1 is > out of bounds. > > Since the "pream" index for accessing ctl_power_table array is initialized > with -1, there is a chance of memory access violation for the cases below. > 1) wmi_pdev_tpc_final_table_event change frequency is between 2483 and 5180 > 2) pream_idx is out of the enumeration ranges of wmi_tpc_pream_2ghz, > wmi_tpc_pream_5ghz > > Signed-off-by: K.T.VIJAYAKUMAAR <vijay.bvb@samsung.com> > [kvalo@codeaurora.org: clean up the warning message] > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 97c69a70dc2c ath10k: avoid possible memory access violation -- https://patchwork.kernel.org/patch/10554929/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ath10k: avoid possible memory access violation 2018-08-03 10:40 ` [PATCH 1/1] ath10k: avoid possible memory access violation K.T.VIJAYAKUMAAR [not found] ` <CGME20180803104058epcas1p1d5cdd51e2774d72679aaf15358cb3d00@epcms5p1> 2018-09-06 16:04 ` Kalle Valo @ 2018-09-06 16:04 ` Kalle Valo 2 siblings, 0 replies; 4+ messages in thread From: Kalle Valo @ 2018-09-06 16:04 UTC (permalink / raw) To: K.T.VIJAYAKUMAAR Cc: davem, ath10k, linux-wireless, netdev, linux-kernel, cpgs, vijay.bvb "K.T.VIJAYAKUMAAR" <vijay.bvb@samsung.com> wrote: > array "ctl_power_table" access index "pream" is initialized with -1 and > is raised as a static analysis tool issue. > [drivers\net\wireless\ath\ath10k\wmi.c:4719] -> > [drivers\net\wireless\ath\ath10k\wmi.c:4730]: (error) Array index -1 is > out of bounds. > > Since the "pream" index for accessing ctl_power_table array is initialized > with -1, there is a chance of memory access violation for the cases below. > 1) wmi_pdev_tpc_final_table_event change frequency is between 2483 and 5180 > 2) pream_idx is out of the enumeration ranges of wmi_tpc_pream_2ghz, > wmi_tpc_pream_5ghz > > Signed-off-by: K.T.VIJAYAKUMAAR <vijay.bvb@samsung.com> > [kvalo@codeaurora.org: clean up the warning message] > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 97c69a70dc2c ath10k: avoid possible memory access violation -- https://patchwork.kernel.org/patch/10554929/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-06 16:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180803104058epcas1p1d5cdd51e2774d72679aaf15358cb3d00@epcas1p1.samsung.com>
2018-08-03 10:40 ` [PATCH 1/1] ath10k: avoid possible memory access violation K.T.VIJAYAKUMAAR
[not found] ` <CGME20180803104058epcas1p1d5cdd51e2774d72679aaf15358cb3d00@epcms5p1>
[not found] ` <20180810101916epcms5p1e3d60d9cbc49f9a7c9529d87d691f359@epcms5p1>
2018-08-10 12:03 ` Kalle Valo
2018-09-06 16:04 ` Kalle Valo
2018-09-06 16:04 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).