From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] xen/netfront: fix waiting for xenbus state change Date: Fri, 07 Sep 2018 23:03:48 -0700 (PDT) Message-ID: <20180907.230348.33221589667753465.davem@davemloft.net> References: <20180907122130.30810-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, boris.ostrovsky@oracle.com, stable@vger.kernel.org To: jgross@suse.com Return-path: In-Reply-To: <20180907122130.30810-1-jgross@suse.com> Sender: stable-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Juergen Gross Date: Fri, 7 Sep 2018 14:21:30 +0200 > Commit 822fb18a82aba ("xen-netfront: wait xenbus state change when load > module manually") added a new wait queue to wait on for a state change > when the module is loaded manually. Unfortunately there is no wakeup > anywhere to stop that waiting. > > Instead of introducing a new wait queue rename the existing > module_unload_q to module_wq and use it for both purposes (loading and > unloading). > > As any state change of the backend might be intended to stop waiting > do the wake_up_all() in any case when netback_changed() is called. > > Fixes: 822fb18a82aba ("xen-netfront: wait xenbus state change when load module manually") > Cc: #4.18 > Signed-off-by: Juergen Gross Applied.