From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net] net_sched: properly cancel netlink dump on failure Date: Fri, 07 Sep 2018 23:05:40 -0700 (PDT) Message-ID: <20180907.230540.1074128809916030289.davem@davemloft.net> References: <20180906215016.399-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dcaratti@redhat.com, simon.horman@netronome.com To: xiyou.wangcong@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:57336 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbeIHKuN (ORCPT ); Sat, 8 Sep 2018 06:50:13 -0400 In-Reply-To: <20180906215016.399-1-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Cong Wang Date: Thu, 6 Sep 2018 14:50:16 -0700 > When nla_put*() fails after nla_nest_start(), we need > to call nla_nest_cancel() to cancel the message, otherwise > we end up calling nla_nest_end() like a success. > > Fixes: 0ed5269f9e41 ("net/sched: add tunnel option support to act_tunnel_key") > Cc: Davide Caratti > Cc: Simon Horman > Signed-off-by: Cong Wang Applied, thanks.