netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vincent.whitchurch@axis.com
Cc: netdev@vger.kernel.org, willemb@google.com, rabinv@axis.com
Subject: Re: [PATCH] tcp: really ignore MSG_ZEROCOPY if no SO_ZEROCOPY
Date: Fri, 07 Sep 2018 23:11:42 -0700 (PDT)	[thread overview]
Message-ID: <20180907.231142.274109264940766007.davem@davemloft.net> (raw)
In-Reply-To: <20180906135459.15529-1-vincent.whitchurch@axis.com>

From: Vincent Whitchurch <vincent.whitchurch@axis.com>
Date: Thu,  6 Sep 2018 15:54:59 +0200

> According to the documentation in msg_zerocopy.rst, the SO_ZEROCOPY
> flag was introduced because send(2) ignores unknown message flags and
> any legacy application which was accidentally passing the equivalent of
> MSG_ZEROCOPY earlier should not see any new behaviour.
> 
> Before commit f214f915e7db ("tcp: enable MSG_ZEROCOPY"), a send(2) call
> which passed the equivalent of MSG_ZEROCOPY without setting SO_ZEROCOPY
> would succeed.  However, after that commit, it fails with -ENOBUFS.  So
> it appears that the SO_ZEROCOPY flag fails to fulfill its intended
> purpose.  Fix it.
> 
> Fixes: f214f915e7db ("tcp: enable MSG_ZEROCOPY")
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>

Applied and queued up for -stable, thanks.

      parent reply	other threads:[~2018-09-08 10:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06 13:54 [PATCH] tcp: really ignore MSG_ZEROCOPY if no SO_ZEROCOPY Vincent Whitchurch
2018-09-06 19:44 ` Willem de Bruijn
2018-09-08  6:11 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180907.231142.274109264940766007.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=rabinv@axis.com \
    --cc=vincent.whitchurch@axis.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).